Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#[should_fail] unit tests are broken on windows #8013

Closed
crnobog opened this issue Jul 23, 2013 · 3 comments
Closed

#[should_fail] unit tests are broken on windows #8013

crnobog opened this issue Jul 23, 2013 · 3 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. O-windows Operating system: Windows

Comments

@crnobog
Copy link

crnobog commented Jul 23, 2013

Running the std unit tests on windows finishes with

running 1042 tests
test ascii::tests::test_ascii ... ok
test ascii::tests::test_ascii_fail_char_slice ... rust: task failed at '955 is not ascii', C:\code\rust\src\libstd\str\ascii.rs:143
rust: domain main @0xb93960 root task failed

Looks like the fail!() that is supposed to cause the test to pass is bringing down the whole executable instead of just the one test. May be related to #7999 .
@bblum
Copy link
Contributor

bblum commented Jul 24, 2013

This is just a symptom of #908. Any test case with #[should_fail] should also have #[ignore(cfg(windows))], so this is probably a bug in an individual test.

@alexcrichton alexcrichton mentioned this issue Jul 24, 2013
Closed
@pnkfelix
Copy link
Member

#908 was closed yesterday, so we should revisit should_fail tests like this.

@sanxiyn
Copy link
Member

sanxiyn commented Dec 9, 2013

This is no more problem (and should_fail tests are run on Windows now).

@sanxiyn sanxiyn closed this as completed Dec 9, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 2, 2021
@bors
Auto merge of rust-lang#8034 - togami2864:non-ascii-in-sigle-literal,…
5a6169d 
… r=llogiq

Non ascii in sigle literal

fix: rust-lang#8013
changelog: `non_ascii_literal` warn against non-ASCII within `char`, not just `strings`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sanxiyn @pnkfelix @crnobog @bblum