Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfail tests that are currently failing on windows, reported in #7999 #8001

Closed
wants to merge 1 commit into from
Closed

xfail tests that are currently failing on windows, reported in #7999 #8001

wants to merge 1 commit into from

Conversation

crnobog
Copy link

@crnobog crnobog commented Jul 23, 2013

No description provided.

@alexcrichton
Copy link
Member

This is a generic problem with windows in that stack unwinding is not implemented yet. This means that task failure is not caught at task boundaries, but rather the entire task dies (same thing as #8013).

This doesn't show up in bors-automated testing because of the xfail-fast tag, but if we're being pedantic about these tests we'd have to be pedantic about every run-pass tests which invokes fail!() at some point (and expects it to be caught at a task boundary).

In the meantime though, could you remove the merge commit via rebasing? bors will add his own when it gets merged in.

@crnobog
Copy link
Author

crnobog commented Jul 24, 2013

Removed the merge commit. I'm fairly new to git so I'm not clear on best practices, thanks for pointing out the mistake.

Re: being pedantic about tests with fail!() - I believe these are the only tests that do so at the moment, because with these changes and the other test-infrastructure related PRs I've added I can run all run-pass tests successfully on windows.

bors added a commit that referenced this pull request Jul 27, 2013
@bors
auto merge of #8001 : crnobog/rust/xfail-win32-7999, r=cmr
c519474
@bors bors closed this Jul 27, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 2, 2021
@bors
Auto merge of rust-lang#8001 - Jarcho:unprefixed_strlen, r=giraffate
908815c 
Improve `strlen_on_c_string`

fixes: rust-lang#7436

changelog: lint `strlen_on_c_string` when used without a fully-qualified path
changelog: suggest removing the surrounding unsafe block for `strlen_on_c_string` when possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crnobog @alexcrichton @emberian @bors