rust deprecated suggestion is wrong for mod

[hellow554]

This is an extension of #84637

First and foremost, thank you @hi-rustin for fixing the original issue in #85018.

Just a quick question: Why did you create a new file instead of extending the existing one?

---

While the code perfectly works for associated functions, it does not work for modules and inner functions.

Given the following code: (Playground)

#![feature(staged_api)]
#![stable(since = "1.0.0", feature = "test")]
#![deny(deprecated)]

mod new {
    #[rustc_deprecated(since = "1.0.0", reason = "Use no", suggestion = "no")]
    #[stable(since = "1.0.0", feature = "test")]
    pub fn yes() {}
    pub fn no() {}
}

#[rustc_deprecated(since = "1.0.0", reason = "Use new", suggestion = "new")]
#[stable(since = "1.0.0", feature = "test")]
mod old {
    pub fn yes() {}
}

fn main() {
    old::yes();
    new::yes();
    new::no();
}

The current output is:

error: use of deprecated function `old::yes`: Use new
  --> src/main.rs:19:5
   |
19 |     old::yes();
   |     ^^^^^^^^ help: replace the use of the deprecated function: `new`
   |
note: the lint level is defined here
  --> src/main.rs:3:9
   |
3  | #![deny(deprecated)]
   |         ^^^^^^^^^^

error: use of deprecated function `new::yes`: Use no
  --> src/main.rs:20:5
   |
20 |     new::yes();
   |     ^^^^^^^^ help: replace the use of the deprecated function: `no`

Ideally the output should look like:

error: use of deprecated function `old::yes`: Use new
  --> src/main.rs:19:5
   |
19 |     old::yes();
   |     ^^^ help: replace the use of the deprecated function: `new`
   |
note: the lint level is defined here
  --> src/main.rs:3:9
   |
3  | #![deny(deprecated)]
   |         ^^^^^^^^^^

error: use of deprecated function `new::yes`: Use no
  --> src/main.rs:20:5
   |
20 |     new::yes();
   |          ^^^ help: replace the use of the deprecated function: `no`

Please note that it still says deprecated function. I'm not entirely sure if rustc_deprecated is allowed on modules, but I guess so.

I think it should say:

error: use of deprecated module `old`: Use new
  --> src/main.rs:19:5
   |
19 |     old::yes();
   |     ^^^ help: replace the use of the deprecated module by: `new`
   |

[hi-rustin]

19 | old::yes();
| ^^^ help: replace the use of the deprecated function: new

Is this a typo?

Just a quick question: Why did you create a new file instead of extending the existing one?

Because I want to bring the number of the issue.

let me try to make it work for modules and inner functions.

@rustbot claim

[hellow554]

Is this a typo?

Not sure what you are refering to. To the old module that should be replaced by new?

[hi-rustin]

Is this a typo?

Not sure what you are refering to. To the old module that should be replaced by new?

I see. No typo. Thanks!

[notriddle]

https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=06aa9f19a94ac57e107f9038577b23a6

   Compiling playground v0.0.1 (/playground)
error: use of deprecated function `old::yes`: Use new
  --> src/main.rs:20:10
   |
20 |     old::yes();
   |          ^^^
   |
note: the lint level is defined here
  --> src/main.rs:4:9
   |
4  | #![deny(deprecated)]
   |         ^^^^^^^^^^
help: replace the use of the deprecated function
   |
20 |     old::new();
   |          ~~~

error: use of deprecated function `new::yes`: Use no
  --> src/main.rs:21:10
   |
21 |     new::yes();
   |          ^^^
   |
help: replace the use of the deprecated function
   |
21 |     new::no();
   |          ~~

error: could not compile `playground` (bin "playground") due to 2 previous errors