shrinking the deprecated span #86320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
0xPoe
changed the title
0xPoe
commented
Jun 15, 2021
| @@ -226,18 +226,19 @@ fn late_report_deprecation( | |||
| suggestion: Option<Symbol>, | |||
| lint: &'static Lint, | |||
| span: Span, | |||
| method_span: Option<Span>, | |||
There was a problem hiding this comment.
Maybe it's not a suitable name for now. But I'm not quite sure what to rename it.
|
@estebank Ping~ Could you please take a look? I would be very grateful. |
JohnCSimon
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 8c5938d has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #85617 (comment)
part of #85403
r? @estebank
The reason is that if we use method_span directly, it will cause the in_derive_expansion judgment to fail.