Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: almost all text is bold #86069

Closed
cynecx opened this issue Jun 6, 2021 · 5 comments · Fixed by #86078
Closed

rustdoc: almost all text is bold #86069

cynecx opened this issue Jun 6, 2021 · 5 comments · Fixed by #86078
Labels
C-bug Category: This is a bug.

Comments

@cynecx
Copy link
Contributor

cynecx commented Jun 6, 2021

rustdoc --version --verbose:

rustdoc 1.54.0-nightly (6c2dd251b 2021-06-05)
binary: rustdoc
commit-hash: 6c2dd251bbff03c7a3092d43fb5b637eca0810e3
commit-date: 2021-06-05
host: x86_64-unknown-linux-gnu
release: 1.54.0-nightly
LLVM version: 12.0.1

Local nalgebra docs:

image

But docs.rs has the same issue: https://docs.rs/nalgebra/0.27.1/nalgebra/geometry/type.Isometry3.html

Probably caused by: #84703 (fab6814) @jsha, @GuillaumeGomez

@cynecx cynecx added the C-bug Category: This is a bug. label Jun 6, 2021
@cynecx
Copy link
Contributor Author

cynecx commented Jun 6, 2021

It seems like this css rule:

.impl, .method,
.type, .associatedconstant,
.associatedtype {
flex-basis: 100%;
font-weight: 600;
margin-top: 16px;
margin-bottom: 10px;
position: relative;
}

applies to this element:

image.

Before (fab6814) this rule wouldn't have applied because it would've been contrained by div[data-level="1"].type instead of .type.

@cynecx
Copy link
Contributor Author

cynecx commented Jun 6, 2021

This also had some other side-effects here:

image

The search results have top/bottom margins compared to the previous styling.

@GuillaumeGomez
Copy link
Member

The second issue was fixed in #86040. I'm checking for the first one, unless you want to send a PR?

@cynecx
Copy link
Contributor Author

cynecx commented Jun 6, 2021

@GuillaumeGomez Hmm, sorry I didn't/don't have much time to dig into this more. I couldn't think of an immediate fix for this because it kinda looked non-trivial (to me) :/

@GuillaumeGomez
Copy link
Member

Don't worry, I'll send a fix in the next hours then.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jun 7, 2021
…t, r=jsha

Type page font weight

Fixes rust-lang#86069.

r? `@jsha`
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jun 8, 2021
…t, r=jsha

Type page font weight

Fixes rust-lang#86069.

r? ``@jsha``
@bors bors closed this as completed in c783e28 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants