-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fn* blanket impls for Arc #89727
Comments
You can just open a pull request adding the implementations, it's not possible to feature gate trait implementations, and you likely don't need an RFC for a smaller change like this. This probably also applies to other pointers as well. |
Got it, thanks! |
Having looked at this much closer, I've learned the following:
Based on discussions in Discord:
My last progress: master...bsodmike:arc_fn_impls Thanks, in no particular order to Discord users helping out:
|
Thanks to Giuschi, we realized there was another approach. Will open a PR shortly. |
Feel free to close this, thanks! |
Hi all,
Apologies if I've opened this issue in the wrong place; I want to work on extending
Box<dyn Fn()>
toArc
.The Boxed implementation has been discussed here: #48055 and added in this PR #59500. Can I use this existing RFC or should we open a new one?
The feature gate could be called
arc_closure_impls
. This discrepancy was discussed by @jonhoo in his latest "Crust of the Rust" episode covering closures etc.The text was updated successfully, but these errors were encountered: