Diagnostics migr const eval #100738
Merged
Diagnostics migr const eval #100738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-translation
rust-highfive
added
the
S-waiting-on-review
|
I added in some more migrations but I'm struggling a bit with their test passes - if anyone could give me some pointers that'd be really appreciated! |
This comment has been minimized.
This comment has been minimized.
Xiretza
reviewed
Aug 20, 2022
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
jeffparsons
reviewed
Aug 20, 2022
Xiretza
reviewed
Aug 21, 2022
This comment has been minimized.
This comment has been minimized.
…reate_feature_err() builder
nidnogg
force-pushed
the
diagnostics_migr_const_eval
branch
from
63c2f86
to
13abae2
Compare
nidnogg
requested review from
davidtwco
and removed request for
compiler-errors
davidtwco
approved these changes
Aug 22, 2022
|
r? @davidtwco |
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 27, 2022
…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#100724 (Migrate ast lowering to session diagnostic) - rust-lang#100735 (Migrate `rustc_ty_utils` to `SessionDiagnostic`) - rust-lang#100738 (Diagnostics migr const eval) - rust-lang#100744 (Migrate rustc_mir_dataflow to diagnostic structs) - rust-lang#100776 (Migrate `rustc_lint` errors to `SessionDiagnostic`) - rust-lang#100817 (sugg: suggest the usage of boolean value when there is a typo in the keyword) - rust-lang#100836 (Migrate `rustc_attr` crate diagnostics) - rust-lang#100890 (Migrate rustc_driver to SessionDiagnostic) - rust-lang#100900 (on `region_errors.rs`) Failed merges: - rust-lang#100831 (Migrate `symbol_mangling` module to new diagnostics structs) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should eventually contain all diagnostic migrations for the
rustc_const_evalcrate.r? @davidtwco
@rustbot label +A-translation