Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix std::collections::HashSet::drain documentation #101330

Merged
merged 1 commit into from Sep 3, 2022

Conversation

wkordalski
Copy link
Contributor

Hi!

std::collections::HashSet::drain contains small typo in the docstring.

I didn't read too much about the model of contributing to Rust, so merge this PR or close and fix the typo the right way :)

Thanks for Rust!

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 2, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2022
@Nilstrieb
Copy link
Member

Haha, HashMap had the same issue #98281, thanks for fixing it

@jyn514
Copy link
Member

jyn514 commented Sep 2, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 2, 2022

📌 Commit 532d5f2 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 2, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 3, 2022
…n514

Fix `std::collections::HashSet::drain` documentation

Hi!

`std::collections::HashSet::drain` contains small typo in the docstring.

I didn't read too much about the model of contributing to Rust, so merge this PR or close and fix the typo the right way :)

Thanks for Rust!
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 3, 2022
Rollup of 7 pull requests

Successful merges:

 - rust-lang#99736 (Partially stabilize `bound_as_ref` by stabilizing `Bound::as_ref`)
 - rust-lang#100928 (Migrate rustc_metadata to SessionDiagnostics)
 - rust-lang#101217 ([drop tracking] Use parent expression for scope, not parent node )
 - rust-lang#101325 (Windows RNG: Use `BCRYPT_RNG_ALG_HANDLE` by default)
 - rust-lang#101330 (Fix `std::collections::HashSet::drain` documentation)
 - rust-lang#101338 (Fix unsupported syntax in .manifest file)
 - rust-lang#101348 (Cleanup css theme)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 414d79d into rust-lang:master Sep 3, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 3, 2022
@wkordalski wkordalski deleted the hashset-drain-doc branch September 16, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants