Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in HashMap::drain docs #98281

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Fix typo in HashMap::drain docs #98281

merged 1 commit into from
Jun 20, 2022

Conversation

Nilstrieb
Copy link
Member

@Nilstrieb Nilstrieb commented Jun 20, 2022 •
edited

It's a map, not a vector.

Fixes #98275.

@Nilstrieb
Fix typo in HashMap::drain docs
2ead0d7 
It's a map, not a vector.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 20, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2022
JohnTitor
JohnTitor approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor
Copy link
Member

r? @JohnTitor @bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 20, 2022

📌 Commit 2ead0d7 has been approved by JohnTitor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2022
@JohnTitor JohnTitor mentioned this pull request Jun 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2022
@bors
Auto merge of rust-lang#98284 - JohnTitor:rollup-7lbs143, r=JohnTitor
4104596 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#98183 (Fix pretty printing of empty bound lists in where-clause)
 - rust-lang#98268 (Improve `lifetime arguments are not allowed on` error message)
 - rust-lang#98273 (Fix minor documentation typo)
 - rust-lang#98274 (Minor improvements on error for `Self` type in items that don't allow it)
 - rust-lang#98281 (Fix typo in `HashMap::drain` docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 66dbc3f into rust-lang:master Jun 20, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 20, 2022
@Nilstrieb Nilstrieb deleted the map-drain-typo branch June 20, 2022 11:55
@Nilstrieb Nilstrieb mentioned this pull request Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

Incorrect doc for drain fn on hahsmap
6 participants
@Nilstrieb @rust-highfive @JohnTitor @bors @Mark-Simulacrum @rustbot