Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug calls #101503

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Add debug calls #101503

merged 2 commits into from
Sep 7, 2022

Conversation

spastorino
Copy link
Member

@oli-obk requested this and other changes as a way of simplifying #101345. This is just going to make the diff of #101345 smaller.

r? @oli-obk @cjgillot

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 6, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2022
@compiler-errors
Copy link
Member

compiler-errors commented Sep 6, 2022 •
edited
Loading

We don't really have standards on what to mark as debug or trace, but do you mind passing over this one more time to make sure that some really-frequently-called functions (or minor ones) are changed debug -> trace, otherwise r=me since this is relatively simple PR

@spastorino
Copy link
Member Author

We don't really have standards on what to mark as debug or trace, but do you mind passing over this one more time to make sure that some really-frequently-called functions (or minor ones) are changed debug -> trace, otherwise r=me since this is relatively simple PR

I've gone ahead and replaced the ones you've noted, but there are still in this file some things that use debug and some others that trace.

I'd say that we should open an issue to, first properly make a policy about this and then change the compiler to do it more properly.

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Sep 7, 2022

📌 Commit 89a7650f9a9b134e32f26f664a47bff18998494f has been approved by compiler-errors

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 7, 2022

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2022
@spastorino
Copy link
Member Author

Ups forgot to force push ...

@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Sep 7, 2022

📌 Commit d42afd2 has been approved by compiler-errors

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 7, 2022

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@spastorino
Copy link
Member Author

@bors rollup

@matthiaskrgr matthiaskrgr mentioned this pull request Sep 7, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2022
@bors
Auto merge of rust-lang#101544 - matthiaskrgr:rollup-4urx917, r=matth…
c2804e6 
…iaskrgr

Rollup of 14 pull requests

Successful merges:

 - rust-lang#101343 (Add -api-level to pm command)
 - rust-lang#101416 (stdio: Document no support for writing to non-blocking stdio/stderr)
 - rust-lang#101435 (Remove unnecessary `EMIT_MIR_FOR_EACH_BITWIDTH`)
 - rust-lang#101493 (Pass ImplTraitContext as &mut to avoid the need of ImplTraitContext::reborrow)
 - rust-lang#101502 (Do not suggest a semicolon for a macro without `!`)
 - rust-lang#101503 (Add debug calls)
 - rust-lang#101506 (rustdoc: remove unused CSS `#main-content > .since`)
 - rust-lang#101507 (rustdoc: remove unused CSS `#main-content > table td`)
 - rust-lang#101521 (Rustdoc-Json: More accurate struct type.)
 - rust-lang#101525 (Fix typo in pass_manager.rs)
 - rust-lang#101534 (rustdoc: remove unused mobile CSS `.rustdoc { flex-direction }`)
 - rust-lang#101535 (Fix error printing mistake in tidy)
 - rust-lang#101536 (Add documentation for Attr::is_doc_comment)
 - rust-lang#101538 (rustdoc: remove unused CSS `.content .methods > div`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0a1c816 into rust-lang:master Sep 7, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@oli-obk oli-obk oli-obk approved these changes

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@spastorino @compiler-errors @bors @oli-obk @rust-highfive @rustbot