Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose AST ranges of definition body bounds in save-analysis data #61596

Closed
asutherland opened this issue Jun 6, 2019 · 1 comment
Closed
Labels
A-save-analysis Area: saving results of analyses such as inference and borrowck results to a file. C-feature-request Category: A feature request, i.e: not implemented / a PR. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.

Comments

@asutherland
Copy link

We've recently updated the Firefox searchfox code indexer to do a "position:sticky" trick so that namespaces/class definitions/method definitions provide context for the source code you're looking at. Our Clang indexer has easy access to the C++ AST to expose this information, but our rust indexer depends on the save-analysis data which only has access to the locations of the token/symbol being defined, not the range of the body of the thing being defined.

It would be invaluable to expose these AST ranges, or have some easy way to reconstruct the AST data given the save-analysis data.

https://bugzilla.mozilla.org/show_bug.cgi?id=1557442 tracks the searchfox enhancement bug that would like this data. For this issue, I think labels A-save-analysis T-dev-tools may be appropriate.

@jonas-schievink jonas-schievink added A-save-analysis Area: saving results of analyses such as inference and borrowck results to a file. C-feature-request Category: A feature request, i.e: not implemented / a PR. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. labels Jun 6, 2019
@jyn514
Copy link
Member

jyn514 commented Feb 19, 2023

Save-analysis has been removed from the compiler.

@jyn514 jyn514 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-save-analysis Area: saving results of analyses such as inference and borrowck results to a file. C-feature-request Category: A feature request, i.e: not implemented / a PR. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants