Lint against escape sequences in Fluent files #109700
Conversation
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
clubby789
force-pushed
the
tidy-fluent-escape
branch
from
5e7c29b
to
c812cdd
Compare
|
Actually, might this make more sense to do during compiling? |
|
I think this could happen during compilation and doesn't need to be a tidy check, yeah. |
clubby789
force-pushed
the
tidy-fluent-escape
branch
from
c812cdd
to
c0ac839
Compare
rustbot
added
the
A-translation
|
|
|
r=me -- if you want to add a test, or not that's also probably ok @bors delegate+ |
|
✌️ @clubby789 can now approve this pull request |
clubby789
force-pushed
the
tidy-fluent-escape
branch
from
c0ac839
to
979c265
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
| LL | fluent_messages! { "./invalid-escape.ftl" } | ||
| | ^^^^^^^^^^^^^^^^^^^^^^ | ||
| | | ||
| = note: os-specific message |
There was a problem hiding this comment.
This is a bit interesting, it's caused by // normalize-stderr-test "note.*" -> "note: os-specific message" in test.rs. It was added because the "could not open Fluent resource" error contains an OS specific error as the note. I think it would be nice if this replacement didn't affect this error.
To give two suggestions how to address this, either one could extend the note of the "could not open" error to something that a better pattern can be made for, or one could move that error into a different file.
One can use fluent quoted strings to avoid the check, if needed: For |
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107387 (Use random `HashMap` keys on Hermit) - rust-lang#109511 (Make `EvalCtxt`'s `infcx` private) - rust-lang#109554 (Suggest ..= when someone tries to create an overflowing range) - rust-lang#109675 (Do not consider elaborated projection predicates for objects in new solver) - rust-lang#109693 (Remove ~const from alloc) - rust-lang#109700 (Lint against escape sequences in Fluent files) - rust-lang#109716 (Move `mir::Field` → `abi::FieldIdx`) - rust-lang#109726 (rustdoc: Don't strip crate module) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
fluent_messages macro: don't emit the OS error in a note This makes it possible to make the normalization of the error message precise, allowing us to not normalize all notes away. See rust-lang#109700 (comment)
Fixes #109686 by checking for
\n,\"and\'in Fluent files. It might be useful to have a way to opt out of this check, but all messages with violations currently do seem to be incorrect.