Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and tidy lint against rust str escape characters in ftl files #109686

Closed
est31 opened this issue Mar 28, 2023 · 0 comments · Fixed by #109700
Closed

Remove and tidy lint against rust str escape characters in ftl files #109686

est31 opened this issue Mar 28, 2023 · 0 comments · Fixed by #109700
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic

Comments

@est31
Copy link
Member

est31 commented Mar 28, 2023

From #109677:

using \n in the messages.ftl file doesn't work

Grepping turns up multiple \n characters in the ftl files. These don't work in fluent however, instead you are supposed to do newlines directly. There should be a tidy lint that forbids such characters, as it's a easy mistake to do during porting. I also see \" escapes that seem not legit.

@rustbot label A-translation

cc @davidtwco

@rustbot rustbot added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Mar 28, 2023
@bors bors closed this as completed in 5937ec1 Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants