Implement volatile_load and volatile_store intrinsics #11173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -349,6 +349,13 @@ pub fn Load(cx: &Block, PointerVal: ValueRef) -> ValueRef { | |||
| } | |||
| } | |||
|
|
|||
| pub fn VolatileLoad(cx: &Block, PointerVal: ValueRef) -> ValueRef { | |||
| unsafe { | |||
| if cx.unreachable.get() { return llvm::LLVMGetUndef(Type::nil().to_ref()); } | |||
There was a problem hiding this comment.
Is returning undef of type nil here actually safe? It seems to be, but I don't understand the details of this operation nor any way to exercise this code path.
|
Updated, tests now check for presence of volatile instructions in bitcode. I think the PR can be merged now. /cc @thestinger |
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| mod rusti { |
There was a problem hiding this comment.
I think this would be better as use std::unstable::intrinsics::{volatile_load, volatile_store}.
There was a problem hiding this comment.
That's what the other intrinsic tests used. I'll fix.
bors
added a commit
that referenced
this pull request
Dec 31, 2013
This PR adds `std::unsafe::intrinsics::{volatile_load,volatile_store}`, which map to LLVM's `load volatile` and `store volatile` operations correspondingly.
This would fix #11172.
I have addressed several uncertainties with this PR in the line comments.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 31, 2023
…=Manishearth Don't lint `needless_return` in fns across a macro boundary Fixes rust-lang#11167 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
std::unsafe::intrinsics::{volatile_load,volatile_store}, which map to LLVM'sload volatileandstore volatileoperations correspondingly.This would fix #11172.
I have addressed several uncertainties with this PR in the line comments.