Fix results search alias display #113823
Merged
Fix results search alias display #113823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
GuillaumeGomez
commented
Jul 18, 2023
| @@ -26,7 +26,7 @@ write: (".search-input", "AliasForTheStdReexport") | |||
| wait-for: "//a[@class='result-import']" | |||
| assert-text: ( | |||
| "a.result-import .result-name", | |||
| "AliasForTheStdReexport - see re-export test_docs::TheStdReexport", | |||
| "re-export AliasForTheStdReexport - see test_docs::TheStdReexport", | |||
There was a problem hiding this comment.
It's quite funny that we didn't realize with this test that something was really wrong. XD
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
fix-results-search-alias-display
branch
from
d220316
to
8f5787a
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 18, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#113811 (Fix removal span calculation of `unused_qualifications` suggestion) - rust-lang#113812 (docs(release): Remove nightly-only cargo item) - rust-lang#113823 (Fix results search alias display) - rust-lang#113824 (a small `fn needs_drop` refactor) - rust-lang#113828 (Ping spastorino on changes to SMIR) - rust-lang#113832 (Add `#[track_caller]` to lint related diagnostic functions) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's displayed like this:
With this fix:
r? @notriddle