Add Alias to smir

[ericmarkmartin]

r? Spastorino

[rustbot]

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

[rustbot]

Could not assign reviewer from: Spastorino.
User(s) Spastorino are either the PR author or are already assigned, and there are no other candidates.
Use r? to specify someone else to assign.

[oli-obk]

r? @spastorino

[rustbot]

Could not assign reviewer from: spastorino.
User(s) spastorino are either the PR author or are already assigned, and there are no other candidates.
Use r? to specify someone else to assign.

[spastorino]

I'd make this match more closely what we have in rustc_middle. So Alias(AliasKind, AliasTy) and AliasTy has the AliasDef and GenericArgs. No big reasons for this, it's just to follow the pattern we have for other variants.

[spastorino]

Looks perfect now.
Last request, can you squash commits?. Maybe you can add a commit with the new documentation of Inherited and the other one with the rest.

[spastorino]

@bors r+ rollup

[bors]

📌 Commit 7ac0ef9 has been approved by spastorino

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7ac0ef9 with merge 98179ad...

[bors]

☀️ Test successful - checks-actions
Approved by: spastorino
Pushing 98179ad to master...

[rust-timer]

Finished benchmarking commit (98179ad): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 651.728s -> 651.172s (-0.09%)