Replace `HashMap` with `IndexMap` in pattern binding resolve #114454

Nilstrieb · 2023-08-04T09:34:51Z

fixes #114332 (comment)

rustbot · 2023-08-04T09:34:56Z

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

compiler/rustc_resolve/src/late.rs

compiler-errors

r=me after cjgillot's nit, i agree that's probably the better approach

bors · 2023-08-20T07:12:15Z

☔ The latest upstream changes (presumably #114332) made this pull request unmergeable. Please resolve the merge conflicts.

compiler/rustc_resolve/src/late.rs

cjgillot · 2023-09-24T10:06:49Z

@bors r+ rollup

bors · 2023-09-24T10:06:51Z

📌 Commit a654b4e has been approved by cjgillot

It is now in the queue for this repository.

Replace `HashMap` with `IndexMap` in pattern binding resolve fixes rust-lang#114332 (comment)

bors · 2023-09-24T14:54:35Z

⌛ Testing commit a654b4e with merge 46c8363...

Replace `HashMap` with `IndexMap` in pattern binding resolve fixes rust-lang#114332 (comment)

bors · 2023-09-24T15:15:12Z

💔 Test failed - checks-actions

Nilstrieb · 2023-09-25T17:54:36Z

i get different results on host x86-64 targetting host and targetting wasm32... what????

Nilstrieb · 2023-09-25T18:19:45Z

there was another hashmap hiding in binding_mode_map. Don't iterate over hashmaps, kids.

cjgillot · 2023-09-26T19:44:37Z

A #[deny(rustc::potential_query_instability)] should help to find those.

It will be iterated over, so we should avoid using `HashMap`.

cjgillot · 2023-10-02T18:03:12Z

@bors r+

bors · 2023-10-02T18:03:15Z

📌 Commit 6ca0723 has been approved by cjgillot

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - rust-lang#114453 (Print GHA log groups to stdout instead of stderr) - rust-lang#114454 (Replace `HashMap` with `IndexMap` in pattern binding resolve ) - rust-lang#116289 (Add missing #[inline] on AsFd impl for sys::unix::fs::File) - rust-lang#116349 (ensure the parent path's existence on `x install`) - rust-lang#116350 (Improve wording of `hint::black_box` docs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#114454 - Nilstrieb:no-evil-sorting, r=cjgillot Replace `HashMap` with `IndexMap` in pattern binding resolve fixes rust-lang#114332 (comment)

rustbot assigned compiler-errors Aug 4, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2023

Nilstrieb mentioned this pull request Aug 4, 2023

Fix ABI flags in RISC-V/LoongArch ELF file generated by rustc #114332

Merged

cjgillot reviewed Aug 4, 2023

View reviewed changes

compiler/rustc_resolve/src/late.rs Outdated Show resolved Hide resolved

compiler-errors reviewed Aug 4, 2023

View reviewed changes

compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2023

rust-cloud-vms bot force-pushed the no-evil-sorting branch 2 times, most recently from b330a2c to 9671262 Compare August 22, 2023 06:36

Nilstrieb changed the title ~~Sort symbols by string for "variable is not bound in all patterns" error~~ Replace HashMap with IndexMap in pattern binding resolve Aug 22, 2023

rust-cloud-vms bot force-pushed the no-evil-sorting branch from 9671262 to 7b47ff0 Compare August 22, 2023 06:37

Nilstrieb added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 22, 2023

rust-cloud-vms bot force-pushed the no-evil-sorting branch from 7b47ff0 to 0209948 Compare August 22, 2023 06:41

This comment has been minimized.

Sign in to view

Nilstrieb added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2023

cjgillot reviewed Aug 22, 2023

View reviewed changes

compiler/rustc_resolve/src/late.rs Outdated Show resolved Hide resolved

compiler/rustc_resolve/src/late.rs Outdated Show resolved Hide resolved

Nilstrieb force-pushed the no-evil-sorting branch from 0209948 to f2eefe3 Compare September 24, 2023 08:53

This comment has been minimized.

Sign in to view

Nilstrieb force-pushed the no-evil-sorting branch from f2eefe3 to a654b4e Compare September 24, 2023 09:33

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 24, 2023

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 24, 2023

Rollup merge of rust-lang#114454 - Nilstrieb:no-evil-sorting, r=cjgillot

a87b9da

Replace `HashMap` with `IndexMap` in pattern binding resolve fixes rust-lang#114332 (comment)

GuillaumeGomez mentioned this pull request Sep 24, 2023

Rollup of 6 pull requests #116119

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 24, 2023

Auto merge of rust-lang#114454 - Nilstrieb:no-evil-sorting, r=cjgillot

46c8363

Replace `HashMap` with `IndexMap` in pattern binding resolve fixes rust-lang#114332 (comment)

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 24, 2023

Nilstrieb force-pushed the no-evil-sorting branch from a654b4e to b6d602e Compare September 25, 2023 18:19

This comment has been minimized.

Sign in to view

compiler-errors assigned cjgillot and unassigned compiler-errors Sep 28, 2023

Replace HashMap with IndexMap in pattern binding resolve

6ca0723

It will be iterated over, so we should avoid using `HashMap`.

Nilstrieb force-pushed the no-evil-sorting branch from b6d602e to 6ca0723 Compare October 2, 2023 17:13

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2023

tmandry mentioned this pull request Oct 2, 2023

Rollup of 5 pull requests #116356

Merged

bors merged commit af77806 into rust-lang:master Oct 2, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 2, 2023

Nilstrieb deleted the no-evil-sorting branch October 3, 2023 04:33

pvdrz mentioned this pull request Oct 4, 2023

Fix divergence from upstream master ferrocene/ferrocene#23

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace `HashMap` with `IndexMap` in pattern binding resolve #114454

Replace `HashMap` with `IndexMap` in pattern binding resolve #114454

Nilstrieb commented Aug 4, 2023

rustbot commented Aug 4, 2023

compiler-errors left a comment

bors commented Aug 20, 2023

This comment has been minimized.

This comment has been minimized.

cjgillot commented Sep 24, 2023

bors commented Sep 24, 2023

bors commented Sep 24, 2023

This comment has been minimized.

bors commented Sep 24, 2023

Nilstrieb commented Sep 25, 2023

Nilstrieb commented Sep 25, 2023 •

edited

This comment has been minimized.

cjgillot commented Sep 26, 2023

cjgillot commented Oct 2, 2023

bors commented Oct 2, 2023

Replace HashMap with IndexMap in pattern binding resolve #114454

Replace HashMap with IndexMap in pattern binding resolve #114454

Conversation

Nilstrieb commented Aug 4, 2023

rustbot commented Aug 4, 2023

compiler-errors left a comment

Choose a reason for hiding this comment

bors commented Aug 20, 2023

This comment has been minimized.

This comment has been minimized.

cjgillot commented Sep 24, 2023

bors commented Sep 24, 2023

bors commented Sep 24, 2023

This comment has been minimized.

bors commented Sep 24, 2023

Nilstrieb commented Sep 25, 2023

Nilstrieb commented Sep 25, 2023 • edited

This comment has been minimized.

cjgillot commented Sep 26, 2023

cjgillot commented Oct 2, 2023

bors commented Oct 2, 2023

Replace `HashMap` with `IndexMap` in pattern binding resolve #114454

Replace `HashMap` with `IndexMap` in pattern binding resolve #114454

Nilstrieb commented Sep 25, 2023 •

edited