Add missing #[inline] on AsFd impl for sys::unix::fs::File #116289

linkmauve · 2023-09-30T15:57:11Z

This operation should be extremely cheap, at most the mov of the underlying file descriptor, but due to this missing #[inline] it is currently a function call.

This operation should be extremely cheap, at most the mov of the underlying file descriptor, but due to this missing #[inline] it is currently a function call.

rustbot · 2023-09-30T15:57:19Z

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

the8472 · 2023-10-02T09:41:57Z

Seems fine, though I wouldn't expect the function call to be particularly expensive in comparison to any syscalls one might be doing on the FDs.

@bors r+

bors · 2023-10-02T09:41:59Z

📌 Commit 133aa56 has been approved by the8472

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - rust-lang#114453 (Print GHA log groups to stdout instead of stderr) - rust-lang#114454 (Replace `HashMap` with `IndexMap` in pattern binding resolve ) - rust-lang#116289 (Add missing #[inline] on AsFd impl for sys::unix::fs::File) - rust-lang#116349 (ensure the parent path's existence on `x install`) - rust-lang#116350 (Improve wording of `hint::black_box` docs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116289 - linkmauve:patch-1, r=the8472 Add missing #[inline] on AsFd impl for sys::unix::fs::File This operation should be extremely cheap, at most the `mov` of the underlying file descriptor, but due to this missing `#[inline]` it is currently a function call.

Add missing #[inline] on AsFd impl for sys::unix::fs::File

133aa56

This operation should be extremely cheap, at most the mov of the underlying file descriptor, but due to this missing #[inline] it is currently a function call.

rustbot assigned cuviper Sep 30, 2023

rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 30, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2023

tmandry mentioned this pull request Oct 2, 2023

Rollup of 5 pull requests #116356

Merged

bors merged commit 1edf723 into rust-lang:master Oct 2, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 2, 2023

pvdrz mentioned this pull request Oct 4, 2023

Fix divergence from upstream master ferrocene/ferrocene#23

Merged

linkmauve deleted the patch-1 branch October 7, 2023 15:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing #[inline] on AsFd impl for sys::unix::fs::File #116289

Add missing #[inline] on AsFd impl for sys::unix::fs::File #116289

linkmauve commented Sep 30, 2023

rustbot commented Sep 30, 2023

the8472 commented Oct 2, 2023

bors commented Oct 2, 2023

Add missing #[inline] on AsFd impl for sys::unix::fs::File #116289

Add missing #[inline] on AsFd impl for sys::unix::fs::File #116289

Conversation

linkmauve commented Sep 30, 2023

rustbot commented Sep 30, 2023

the8472 commented Oct 2, 2023

bors commented Oct 2, 2023