Ensure that `~const` trait bounds on associated functions are in const traits or impls #116210

Raekye · 2023-09-27T21:31:16Z

Zulip discussion: https://rust-lang.zulipchat.com/#narrow/stream/146212-t-compiler.2Fconst-eval/topic/How.20to.2Fshould.20I.20try.20to.20pinpoint.20ICEs.20related.20to.20effects.3F

rustbot · 2023-09-27T21:31:24Z

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

fee1-dead · 2023-09-28T10:34:18Z

r? fee1-dead

tests/ui/rfcs/rfc-2632-const-trait-impl/trait-where-clause.rs

tests/ui/rfcs/rfc-2632-const-trait-impl/effects/const-bound-on-not-const-associated-fn.rs

compiler/rustc_ast_passes/src/ast_validation.rs

@fee1-dead

Previously, any associated function could have `~const` trait bounds on generic parameters, which could lead to ICEs when these bounds were used on associated functions of non-`#[const_trait] trait` or non-`impl const` blocks. Includes changes as per @fee1-dead's comments in rust-lang#116210.

fee1-dead

LGTM!

fee1-dead · 2023-10-01T06:17:21Z

@bors r+

bors · 2023-10-01T06:17:23Z

📌 Commit 884af36 has been approved by fee1-dead

It is now in the queue for this repository.

bors · 2023-10-01T09:55:30Z

⌛ Testing commit 884af36 with merge e4a69c1...

Ensure that `~const` trait bounds on associated functions are in const traits or impls Zulip discussion: https://rust-lang.zulipchat.com/#narrow/stream/146212-t-compiler.2Fconst-eval/topic/How.20to.2Fshould.20I.20try.20to.20pinpoint.20ICEs.20related.20to.20effects.3F

rust-log-analyzer · 2023-10-01T11:05:07Z

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

tests\ui-toml\undocumented_unsafe_blocks\undocumented_unsafe_blocks.rs (default) ... ok
tests\ui-toml\undocumented_unsafe_blocks\undocumented_unsafe_blocks.rs (disabled) ... ok

tests\ui-toml\doc_valid_idents_replace\doc_markdown.rs FAILED:
command: "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\clippy-driver.exe" "--error-format=json" "--emit=metadata" "-Aunused" "-Ainternal_features" "-Zui-testing" "-Dwarnings" "-Ldependency=C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps" "--extern=clippy_lints=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libclippy_lints-a98ad1e28ba17d29.rlib" "--extern=clippy_utils=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libclippy_utils-70663d4c9a199787.rlib" "--extern=futures=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libfutures-a074388a1bf2e009.rlib" "--extern=if_chain=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libif_chain-ba0253edeba7a8f0.rlib" "--extern=itertools=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libitertools-6894b4f3e8c5523f.rlib" "--extern=parking_lot=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libparking_lot-f87e1900e520ff9b.rlib" "--extern=quote=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libquote-3ebce4a1d5d43cf1.rlib" "--extern=regex=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libregex-3e46ad2dfdd0c657.rlib" "--extern=serde=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libserde-12500b7f802b2beb.rlib" "--extern=serde_derive=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\release\\deps\\serde_derive-67ed154847593e2b.dll" "--extern=syn=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libsyn-bc3ce53f417d339c.rlib" "--extern=tokio=\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\x86_64-pc-windows-msvc\\release\\deps\\libtokio-159ee9fbda356223.rlib" "-Ldependency=C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\release\\deps" "--out-dir" "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools\\ui_test" "tests\\ui-toml\\doc_valid_idents_replace\\doc_markdown.fixed" "--edition" "2021" "--crate-name" "doc_markdown"
called `Result::unwrap()` on an `Err` value: tests failed

Location:
    C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\ui_test-0.20.0\src\lib.rs:362:13
    C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\ui_test-0.20.0\src\lib.rs:362:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

rustfix failed with exit code: 1

full stderr:
error: failed to write \\?\C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\ui_test\libdoc_markdown.rmeta: Access is denied. (os error 5)
error: aborting due to previous error


full stdout:

bors · 2023-10-01T11:05:32Z

💔 Test failed - checks-actions

fee1-dead · 2023-10-03T09:48:42Z

Spurious: Access is denied. (os error 5)

@bors retry

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#115863 (Add check_unused_messages in tidy) - rust-lang#116210 (Ensure that `~const` trait bounds on associated functions are in const traits or impls) - rust-lang#116358 (Rename both of the `Match` relations) - rust-lang#116371 (Remove unused features from `rustc_llvm`.) - rust-lang#116374 (Print normalized ty) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116210 - Raekye:master, r=fee1-dead Ensure that `~const` trait bounds on associated functions are in const traits or impls Zulip discussion: https://rust-lang.zulipchat.com/#narrow/stream/146212-t-compiler.2Fconst-eval/topic/How.20to.2Fshould.20I.20try.20to.20pinpoint.20ICEs.20related.20to.20effects.3F

rustbot assigned wesleywiser Sep 27, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 27, 2023

rustbot assigned fee1-dead and unassigned wesleywiser Sep 28, 2023

fee1-dead reviewed Sep 28, 2023

View reviewed changes

Raekye added a commit to Raekye/rust that referenced this pull request Sep 28, 2023

Apply changes as per @fee1-dead's comments in rust-lang#116210.

79ae722

fee1-dead reviewed Sep 29, 2023

View reviewed changes

compiler/rustc_ast_passes/src/ast_validation.rs Outdated Show resolved Hide resolved

fee1-dead marked this pull request as ready for review September 29, 2023 08:45

Raekye force-pushed the master branch from 79ae722 to 884af36 Compare September 30, 2023 23:05

fee1-dead changed the title ~~Validate that ~const trait bounds on associated functions (fixes ICEs)~~ Ensure that ~const trait bounds on associated functions are in const traits or impls Oct 1, 2023

fee1-dead approved these changes Oct 1, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 1, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2023

matthiaskrgr mentioned this pull request Oct 3, 2023

Rollup of 5 pull requests #116376

Merged

bors merged commit fa1cbac into rust-lang:master Oct 3, 2023
11 of 12 checks passed

rustbot added this to the 1.75.0 milestone Oct 3, 2023

pvdrz mentioned this pull request Oct 4, 2023

Fix divergence from upstream master ferrocene/ferrocene#23

Merged

fee1-dead mentioned this pull request Dec 6, 2023

Tracking Issue for removing impl const and ~const in the standard library #110395

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure that `~const` trait bounds on associated functions are in const traits or impls #116210

Ensure that `~const` trait bounds on associated functions are in const traits or impls #116210

Raekye commented Sep 27, 2023

rustbot commented Sep 27, 2023

fee1-dead commented Sep 28, 2023

fee1-dead left a comment •

edited

fee1-dead commented Oct 1, 2023

bors commented Oct 1, 2023

bors commented Oct 1, 2023

rust-log-analyzer commented Oct 1, 2023

bors commented Oct 1, 2023

fee1-dead commented Oct 3, 2023

Ensure that ~const trait bounds on associated functions are in const traits or impls #116210

Ensure that ~const trait bounds on associated functions are in const traits or impls #116210

Conversation

Raekye commented Sep 27, 2023

rustbot commented Sep 27, 2023

fee1-dead commented Sep 28, 2023

fee1-dead left a comment • edited

Choose a reason for hiding this comment

fee1-dead commented Oct 1, 2023

bors commented Oct 1, 2023

bors commented Oct 1, 2023

rust-log-analyzer commented Oct 1, 2023

bors commented Oct 1, 2023

fee1-dead commented Oct 3, 2023

Ensure that `~const` trait bounds on associated functions are in const traits or impls #116210

Ensure that `~const` trait bounds on associated functions are in const traits or impls #116210

fee1-dead left a comment •

edited