handle the case when the change-id isn't found #117263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
onur-ozkan
force-pushed
the
change-id-fix
branch
from
913daa7
to
21a2130
Compare
|
-kindly reminder ping- @saethlin |
saethlin
reviewed
Nov 4, 2023
|
Thanks for reminding me, this PR fell out of my work queue. The new warning looks good, just if I understand the implementation of @rustbot author |
rustbot
added
S-waiting-on-author
onur-ozkan
added
S-waiting-on-review
|
r=me when you resolve the conflicts, thanks for being so patient with me :) |
onur-ozkan
force-pushed
the
change-id-fix
branch
from
684a502
to
966c102
Compare
|
@bors r=saethlin rollup |
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
Nov 8, 2023
handle the case when the change-id isn't found When we switch back and forth between the old and recent branches, if there was a breaking change in the bootstrap configuration in between, we have to update the change-id in the build configuration with each checkout, which can be exhausting. This change fixes that. r? saethlin
|
☔ The latest upstream changes (presumably #116881) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
When we switch back and forth between the old and recent branches, if there was a breaking change in the bootstrap configuration in between, we have to update the change-id in the build configuration with each checkout, which can be exhausting. This change fixes that. Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
force-pushed
the
change-id-fix
branch
from
966c102
to
e0cb1cc
Compare
|
@bors r=saethlin |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 8, 2023
handle the case when the change-id isn't found When we switch back and forth between the old and recent branches, if there was a breaking change in the bootstrap configuration in between, we have to update the change-id in the build configuration with each checkout, which can be exhausting. This change fixes that. r? saethlin
This was referenced Nov 8, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 8, 2023
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#117263 (handle the case when the change-id isn't found) - rust-lang#117282 (Recover from incorrectly ordered/duplicated function keywords) - rust-lang#117679 (tests/rustdoc-json: Avoid needless use of `no_core` and `lang_items`) - rust-lang#117702 (target: move base and target specifications) - rust-lang#117713 (Add test for reexported hidden item with `--document-hidden-items`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 8, 2023
Rollup merge of rust-lang#117263 - onur-ozkan:change-id-fix, r=saethlin handle the case when the change-id isn't found When we switch back and forth between the old and recent branches, if there was a breaking change in the bootstrap configuration in between, we have to update the change-id in the build configuration with each checkout, which can be exhausting. This change fixes that. r? saethlin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switch back and forth between the old and recent branches, if there was a breaking change in the bootstrap configuration in between, we have to update the change-id in the build configuration with each checkout, which can be exhausting. This change fixes that.
r? saethlin