Recover from incorrectly ordered/duplicated function keywords #117282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
rust-cloud-vms
bot
force-pushed
the
recover-wrong-function-header
branch
from
b769520
to
82644aa
Compare
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
recover-wrong-function-header
branch
from
82644aa
to
be0b42f
Compare
TaKO8Ki
reviewed
Oct 28, 2023
Comment on lines
-4
to
-13
| LL | impl S { | ||
| | - while parsing this item list starting here | ||
| LL | #[cfg(FALSE)] | ||
| LL | unsafe async fn g() {} | ||
| | -------^^^^^ | ||
| | | | | ||
| | | expected one of `extern` or `fn` | ||
| | help: `async` must come before `unsafe`: `async unsafe` | ||
| LL | } | ||
| | - the item list ends here |
There was a problem hiding this comment.
Ideally, I think it's best to leave this as it is.
There was a problem hiding this comment.
Hmm, this message indicates that it wasn't able to recover the rest of the item list if I understand right? I think this is an improvement as it's able to continue parsing other items in the list, so the message isn't really necessary
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 8, 2023
…eader, r=TaKO8Ki Recover from incorrectly ordered/duplicated function keywords Fixes rust-lang#115714
This was referenced Nov 8, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 8, 2023
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#117263 (handle the case when the change-id isn't found) - rust-lang#117282 (Recover from incorrectly ordered/duplicated function keywords) - rust-lang#117679 (tests/rustdoc-json: Avoid needless use of `no_core` and `lang_items`) - rust-lang#117702 (target: move base and target specifications) - rust-lang#117713 (Add test for reexported hidden item with `--document-hidden-items`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 8, 2023
Rollup merge of rust-lang#117282 - clubby789:recover-wrong-function-header, r=TaKO8Ki Recover from incorrectly ordered/duplicated function keywords Fixes rust-lang#115714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115714