Subtree update of `rust-analyzer` #117985

lnicola · 2023-11-16T20:09:33Z

Out of band, but required for #117981.

…m-ra

They've been deprecated for four years. This commit includes the following changes. - It eliminates the `rustc_plugin_impl` crate. - It changes the language used for lints in `compiler/rustc_driver_impl/src/lib.rs` and `compiler/rustc_lint/src/context.rs`. External lints are now called "loaded" lints, rather than "plugins" to avoid confusion with the old plugins. This only has a tiny effect on the output of `-W help`. - E0457 and E0498 are no longer used. - E0463 is narrowed, now only relating to unfound crates, not plugins. - The `plugin` feature was moved from "active" to "removed". - It removes the entire plugins chapter from the unstable book. - It removes quite a few tests, mostly all of those in `tests/ui-fulldeps/plugin/`. Closes rust-lang#29597.

…m-ra

feat: preview adt field when hover Closes rust-lang#13977 ![20231108194345_rec_](https://github.com/rust-lang/rust-analyzer/assets/14040068/95894c4b-de6e-4ca4-98b3-6ab4559d0950)

…mment, r=lnicola Try to update parser/event doc `TokenSource` and `TreeSink` has been refactored as part of rust-lang#10765, they no longer exist in code repo. This pr tries to remove them from event module level comment to prevent confusion.

…Kalbasi Truncate closure capture place for raw pointer fix rust-lang/rust-analyzer#15670 (comment)

fix: find `Self` reference took a lot of time to debug to find the problem, here should compare the actual `Adt` type close rust-lang/rust-analyzer#12693

…lnicola fix: Ignore doc(hidden) attr if no body is present fixes rust-lang#15782

Improve check for include macro rust-lang/rust-analyzer#15819 (review)

Add config for preferring / ignoring prelude modules in find_path

Mirrors `PathSegment's` version, except that it always generates a turbofish

`add_type_ascription` is still left as-is since it's a different assist

Way for setting and removing the type ascription of a let stmt

Due to the way the current tree mutation api works, we need to collect changes before we can apply them to the real syntax tree, and also can only switch to a file once. `destructure_tuple_binding_in_sub_pattern` also gets migrated even though can't be used.

lnicola · 2023-11-16T20:10:16Z

@bors r+ p=1 subtree sync

bors · 2023-11-16T20:10:20Z

📌 Commit 3507a09 has been approved by lnicola

It is now in the queue for this repository.

lnicola · 2023-11-16T20:26:56Z

@bors r-

…m-ra

lnicola · 2023-11-16T20:28:12Z

@bors r+ p=1 subtree sync

bors · 2023-11-16T20:28:15Z

📌 Commit 949870c has been approved by lnicola

It is now in the queue for this repository.

bors · 2023-11-16T23:16:53Z

⌛ Testing commit 949870c with merge 2c962ec...

Subtree update of `rust-analyzer` r? `@ghost` Out of band, but required for rust-lang#117981.

rust-log-analyzer · 2023-11-17T00:02:23Z

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING] core::build_steps::tool::ToolBuild { compiler: Compiler { stage: 1, host: aarch64-unknown-linux-gnu }, target: aarch64-unknown-linux-gnu, tool: "error_index_generator", path: "src/tools/error_index_generator", mode: ToolRustc, is_optional_tool: false, source_type: InTree, extra_features: [], allow_features: "" } -- 44.021
[TIMING] core::build_steps::tool::ErrorIndex { compiler: Compiler { stage: 1, host: aarch64-unknown-linux-gnu } } -- 0.000
[TIMING] core::build_steps::doc::ErrorIndex { target: aarch64-unknown-linux-gnu } -- 2.800
Rustbook (aarch64-unknown-linux-gnu) - nomicon
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
##[group]Clock drift check
  local time: Fri Nov 17 00:02:00 UTC 2023
  local time: Fri Nov 17 00:02:00 UTC 2023
Session terminated, killing shell... ...killed.
##[error]The operation was canceled.
Cleaning up orphan processes

bors · 2023-11-17T00:02:48Z

💔 Test failed - checks-actions

lnicola · 2023-11-17T02:56:06Z

@bors retry runner quit

bors · 2023-11-17T05:56:03Z

⌛ Testing commit 949870c with merge 00bfd6b...

bors · 2023-11-17T07:52:32Z

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 00bfd6b to master...

rust-timer · 2023-11-17T09:15:04Z

Finished benchmarking commit (00bfd6b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.6%, 2.3%]	2
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-1.8%	[-2.8%, -0.8%]	2
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	1
All ❌✅ (primary)	0.1%	[-2.8%, 2.3%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.8%, 0.9%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.9%	[0.8%, 0.9%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.51s -> 675.609s (-0.13%)
Artifact size: 313.61 MiB -> 313.59 MiB (-0.01%)

lnicola and others added 30 commits September 18, 2023 12:33

Merge commit '258b15c506a2d3ad862fd17ae24eaf272443f477' into sync-fro…

bcfc997

…m-ra

use visibility to check unused imports and delete some stmts

d204713

Merge commit '3b7c7f97e4a7bb253a8d398ee4f8346f6cf2817b' into sync-fro…

d1d111d

…m-ra

feat: preview adt field when hover

41bcd54

Auto merge of rust-lang#15847 - wasd96040501:feat/preview_adt, r=lnicola

7059ae2

feat: preview adt field when hover Closes rust-lang#13977 ![20231108194345_rec_](https://github.com/rust-lang/rust-analyzer/assets/14040068/95894c4b-de6e-4ca4-98b3-6ab4559d0950)

Try to update parser doc

fa7a918

Ignore doc(hidden) attr if no body is present

b0101da

Truncate closure capture place for raw pointer

3bcdb7d

Auto merge of rust-lang#15860 - HKalbasi:fix-capture-raw-pointer, r=H…

7663319

…Kalbasi Truncate closure capture place for raw pointer fix rust-lang/rust-analyzer#15670 (comment)

fix: find Self reference

e0276dc

Auto merge of rust-lang#15864 - Young-Flash:find_self, r=lnicola

5afaf68

fix: find `Self` reference took a lot of time to debug to find the problem, here should compare the actual `Adt` type close rust-lang/rust-analyzer#12693

Auto merge of rust-lang#15854 - alibektas:15782/relax_hidden_attr, r=…

7cca4e5

…lnicola fix: Ignore doc(hidden) attr if no body is present fixes rust-lang#15782

Improve check for include macro

9826717

Auto merge of rust-lang#15866 - lnicola:include-check, r=Veykril

11a87c9

Improve check for include macro rust-lang/rust-analyzer#15819 (review)

Prepare ImportMap for supportin multiple import paths per item

2339ba4

Record all import paths per item in ImportMap

801a887

Add config for preferring / ignoring prelude modules in find_path

ba61766

Fix some FIXMEs

74e5444

Auto merge of rust-lang#15871 - Veykril:import-map, r=Veykril

5fcf528

Add config for preferring / ignoring prelude modules in find_path

docs: fix VS Code setting samples

b6f0994

Add MethodCallExpr::get_or_create_generic_arg_list

02c7b8b

Mirrors `PathSegment's` version, except that it always generates a turbofish

Migrate add_turbo_fish to mutable ast

cc4e06f

`add_type_ascription` is still left as-is since it's a different assist

Use syntax's version of SyntaxElement

92422f7

Add LetStmt::set_ty

5fc8cc5

Way for setting and removing the type ascription of a let stmt

Migrate add_type_ascription

f3dcc67

Allow multiple snippet edits in a TextDocumentEdit

1e46868

fix PathSegment grammar

23fde40

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2023

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 16, 2023

Merge commit '141fc695dca1df7cfc3c9803972ec19bb178dcbc' into sync-fro…

949870c

…m-ra

lnicola force-pushed the sync-from-ra branch from 3507a09 to 949870c Compare November 16, 2023 20:27

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 16, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2023

Auto merge of rust-lang#117985 - lnicola:sync-from-ra, r=lnicola

2c962ec

Subtree update of `rust-analyzer` r? `@ghost` Out of band, but required for rust-lang#117981.

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 17, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 17, 2023

bors merged commit 00bfd6b into rust-lang:master Nov 17, 2023
12 checks passed

rustbot added this to the 1.76.0 milestone Nov 17, 2023

lnicola deleted the sync-from-ra branch November 17, 2023 07:56

lnicola mentioned this pull request Nov 17, 2023

Please update rust-analyzer in rust-lang/rust rust-lang/rust-analyzer#15776

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subtree update of `rust-analyzer` #117985

Subtree update of `rust-analyzer` #117985

lnicola commented Nov 16, 2023

lnicola commented Nov 16, 2023

bors commented Nov 16, 2023

lnicola commented Nov 16, 2023

lnicola commented Nov 16, 2023

bors commented Nov 16, 2023

bors commented Nov 16, 2023

rust-log-analyzer commented Nov 17, 2023

bors commented Nov 17, 2023

lnicola commented Nov 17, 2023

bors commented Nov 17, 2023

bors commented Nov 17, 2023

rust-timer commented Nov 17, 2023

Subtree update of rust-analyzer #117985

Subtree update of rust-analyzer #117985

Conversation

lnicola commented Nov 16, 2023

lnicola commented Nov 16, 2023

bors commented Nov 16, 2023

lnicola commented Nov 16, 2023

lnicola commented Nov 16, 2023

bors commented Nov 16, 2023

bors commented Nov 16, 2023

rust-log-analyzer commented Nov 17, 2023

bors commented Nov 17, 2023

lnicola commented Nov 17, 2023

bors commented Nov 17, 2023

bors commented Nov 17, 2023

rust-timer commented Nov 17, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Subtree update of `rust-analyzer` #117985

Subtree update of `rust-analyzer` #117985