Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra tries to find rustrt, but make install doesn't install it #10765

Closed
klutzy opened this issue Dec 2, 2013 · 1 comment · Fixed by #10770
Closed

extra tries to find rustrt, but make install doesn't install it #10765

klutzy opened this issue Dec 2, 2013 · 1 comment · Fixed by #10770

Comments

@klutzy
Copy link
Contributor

klutzy commented Dec 2, 2013 

$ cd ~/tmp
$ export PATH=$PATH:/home/it/usr/rust-61443dc/bin
$ cat o_o.rs
extern mod extra;
fn main() {}

$ rustc.exe o_o.rs
error: linking with `g++` failed: exit code: 1
note: g++ arguments: '-m32' '-LC:\home\usr\rust-61443dc\bin\rustc\i686-pc-mingw32\bin' '-o' 'o_o' 'o_o.o' 'C:\home\usr\rust-61443dc\bin\rustc\i686-pc-mingw32\bin\libstd-6425b930ca146ae9-0.9-pre.rlib' 'C:\home\usr\rust-61443dc\bin\rustc\i686-pc-mingw32\bin\librustuv-a13edc95d75df17-0.9-pre.rlib' '-lpthread' '-lws2_32' '-lpsapi' '-liphlpapi'
'C:\home\usr\rust-61443dc\bin\rustc\i686-pc-mingw32\bin\libextra-aaa96aab146eb38e-0.9-pre.rlib' '-lrustrt' '-LC:\home\tmp\.rust' '-LC:\home\tmp' '-lmorestack'
note: c:/home/usr/mingw-20120426/bin/../lib/gcc/mingw32/4.6.2/../../../../mingw32/bin/ld.exe: cannot find -lrustrt

The error disappears when extern mod extra is removed.

Edit: Changing title since I've heard similar result on linux. (--test build failure on ubuntu nightly)
The core issue is 1) extra needs rustrt 2) but make install doesn't install it.
@alexcrichton alexcrichton mentioned this issue Dec 2, 2013
Merged
@alexcrichton
Copy link
Member

I forgot to add kind = "static" to the link declaration.

bors added a commit that referenced this issue Dec 3, 2013
@bors
auto merge of #10770 : alexcrichton/rust/static-librustrt, r=alexcric…
fc3b7c1 
…hton

This wasn't uncovered during testing because the librustrt is available locally
in the build directory (and it needs to be for all the tests to link against it
as well).

Closes #10765
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 30, 2023
@Centri3
to_xx_bytes implemented, from_xx_bytes todo
3ab6aee 
Mentioned in rust-lang#10765
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 30, 2023
@bors
Auto merge of rust-lang#10826 - Centri3:endian_bytes, r=Manishearth
eacd095 
Add lints for disallowing usage of `to_xx_bytes` and `from_xx_bytes`

Adds `host_endian_bytes`, `little_endian_bytes` and `big_endian_bytes`

Closes rust-lang#10765

v - not sure what to put here since this adds 3 lints
changelog: Add `host_endian_bytes`, `little_endian_bytes` and `big_endian_bytes` lints
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 16, 2023
@bors
Auto merge of rust-lang#15853 - Kangaxx-0:gaxx/update-parser-event-co…
ebb9ed9 
…mment, r=lnicola

Try to update parser/event doc

`TokenSource` and `TreeSink` has been refactored as part of rust-lang#10765, they no longer exist in code repo. This pr tries to remove them from event module level comment to prevent confusion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Declare librustrt a static dependency of libextra alexcrichton/rust
2 participants
@alexcrichton @klutzy