Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtree update of rust-analyzer #117985

Merged
merged 98 commits into from
Nov 17, 2023
Merged

Subtree update of rust-analyzer #117985

merged 98 commits into from
Nov 17, 2023

Commits on Sep 18, 2023

  1. Configuration menu
    Copy the full SHA
    bcfc997 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. Configuration menu
    Copy the full SHA
    d204713 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Remove support for compiler plugins.

    They've been deprecated for four years.
    
    This commit includes the following changes.
    - It eliminates the `rustc_plugin_impl` crate.
    - It changes the language used for lints in
      `compiler/rustc_driver_impl/src/lib.rs` and
      `compiler/rustc_lint/src/context.rs`. External lints are now called
      "loaded" lints, rather than "plugins" to avoid confusion with the old
      plugins. This only has a tiny effect on the output of `-W help`.
    - E0457 and E0498 are no longer used.
    - E0463 is narrowed, now only relating to unfound crates, not plugins.
    - The `plugin` feature was moved from "active" to "removed".
    - It removes the entire plugins chapter from the unstable book.
    - It removes quite a few tests, mostly all of those in
      `tests/ui-fulldeps/plugin/`.
    
    Closes rust-lang#29597.
    nnethercote committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    6eaf3f8 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Configuration menu
    Copy the full SHA
    d1d111d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    41bcd54 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7059ae2 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Try to update parser doc

    Kangaxx-0 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    fa7a918 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b0101da View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3bcdb7d View commit details
    Browse the repository at this point in the history
  4. Auto merge of rust-lang#15853 - Kangaxx-0:gaxx/update-parser-event-co…

    …mment, r=lnicola
    
    Try to update parser/event doc
    
    `TokenSource` and `TreeSink` has been refactored as part of rust-lang#10765, they no longer exist in code repo. This pr tries to remove them from event module level comment to prevent confusion.
    bors committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ebb9ed9 View commit details
    Browse the repository at this point in the history
  5. Auto merge of rust-lang#15860 - HKalbasi:fix-capture-raw-pointer, r=H…

    …Kalbasi
    
    Truncate closure capture place for raw pointer
    
    fix rust-lang/rust-analyzer#15670 (comment)
    bors committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    7663319 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. fix: find Self reference

    Young-Flash committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    e0276dc View commit details
    Browse the repository at this point in the history
  2. Auto merge of rust-lang#15864 - Young-Flash:find_self, r=lnicola

    fix: find `Self` reference
    
    took a lot of time to debug to find the problem, here should compare the actual `Adt` type
    
    close rust-lang/rust-analyzer#12693
    bors committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    5afaf68 View commit details
    Browse the repository at this point in the history
  3. Auto merge of rust-lang#15854 - alibektas:15782/relax_hidden_attr, r=…

    …lnicola
    
    fix: Ignore doc(hidden) attr if no body is present
    
    fixes rust-lang#15782
    bors committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    7cca4e5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9826717 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    11a87c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Configuration menu
    Copy the full SHA
    2339ba4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    801a887 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba61766 View commit details
    Browse the repository at this point in the history
  4. Fix some FIXMEs

    Veykril committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    74e5444 View commit details
    Browse the repository at this point in the history
  5. Auto merge of rust-lang#15871 - Veykril:import-map, r=Veykril

    Add config for preferring / ignoring prelude modules in find_path
    bors committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    5fcf528 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2023

  1. Configuration menu
    Copy the full SHA
    b6f0994 View commit details
    Browse the repository at this point in the history
  2. Add MethodCallExpr::get_or_create_generic_arg_list

    Mirrors `PathSegment's` version, except that it always generates a
    turbofish
    DropDemBits committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    02c7b8b View commit details
    Browse the repository at this point in the history
  3. Migrate add_turbo_fish to mutable ast

    `add_type_ascription` is still left as-is since it's a different assist
    DropDemBits committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    cc4e06f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    92422f7 View commit details
    Browse the repository at this point in the history
  5. Add LetStmt::set_ty

    Way for setting and removing the type ascription of a let stmt
    DropDemBits committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    5fc8cc5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f3dcc67 View commit details
    Browse the repository at this point in the history
  7. Migrate destructure_tuple_binding to mutable ast

    Due to the way the current tree mutation api works, we need to collect
    changes before we can apply them to the real syntax tree, and also can only
    switch to a file once.
    
    `destructure_tuple_binding_in_sub_pattern` also gets migrated even
    though can't be used.
    DropDemBits committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    4aaa592 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1e46868 View commit details
    Browse the repository at this point in the history
  9. fix PathSegment grammar

    Young-Flash committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    23fde40 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    cace36c View commit details
    Browse the repository at this point in the history
  11. Auto merge of rust-lang#15870 - lnicola:expand-macro, r=lnicola

    minor: Make "Expand macro" command title more explicit
    
    Closes [rust-lang#15856](rust-lang/rust-analyzer#15856).
    
    I opted for "caret", since it's the better term (cursor is the mouse), but I'm not sure how popular it is these days.
    bors committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    1152f59 View commit details
    Browse the repository at this point in the history
  12. Include toml files in the vfs

    lnicola committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    bad3d9e View commit details
    Browse the repository at this point in the history
  13. Auto merge of rust-lang#15880 - lnicola:vfs-toml, r=Veykril

    internal: Include toml files in the vfs
    
    Closes rust-lang#15753
    bors committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    8bfe0aa View commit details
    Browse the repository at this point in the history
  14. Auto merge of rust-lang#15876 - DropDemBits:lsp-ext-multiple-snippet-…

    …textedit, r=Veykril
    
    minor: Allow multiple snippet edits in a `TextDocumentEdit`
    
    Explicitly[^1] allow a single `TextDocumentEdit` to have multiple `SnippetTextEdit`s. This allows things like renaming extracted variables and functions without having to go through a separate rename step. For an example of what this looks like, see the video in [this comment](microsoft/vscode#145374 (comment)).
    
    The behavior described here lines up with [what VSCode does](https://github.com/microsoft/vscode/blob/bdc113ffe148a92d0e1a8ec34b12c44ea0b73f29/src/vscode-dts/vscode.d.ts#L3728-L3731), and presumably what the eventual LSP behavior will be.
    
    [^1]: This was technically the case before rust-lang#15269, a single `TextDocumentEdit` always had multiple edits which were `InsertTextFormat.Snippet` as all of the edits were marked as being snippets, even if there weren't any tab stops or placeholders.
    bors committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    92d9ca7 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    d6b908e View commit details
    Browse the repository at this point in the history
  16. Auto merge of rust-lang#15882 - Veykril:fix-config-keys, r=Veykril

    minor: Fix import preference config keys
    bors committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    4fc208e View commit details
    Browse the repository at this point in the history
  17. Auto merge of rust-lang#15881 - nokazn:docs/fix-vscode-setting-sample…

    …s, r=lnicola
    
    docs: fix VS Code setting samples
    
    Fix invalid JSONC examples (missing double quotes) in VS Code's `settings.json` .
    Thank you.
    bors committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    416e9c8 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Configuration menu
    Copy the full SHA
    3e5bc9a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b6951de View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6f68cd3 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Add IdentPat::set_pat

    Needed so that the `tuple_pat` node gets added to the syntax tree,
    which is required as we're using structured snippets.
    DropDemBits committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    787ca88 View commit details
    Browse the repository at this point in the history
  2. Simplify

    Veykril committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e844784 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b740155 View commit details
    Browse the repository at this point in the history
  4. Depend on rustc_driver

    lnicola committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    d45ff24 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6ddccc9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d5faad1 View commit details
    Browse the repository at this point in the history
  7. Auto merge of rust-lang#15891 - Veykril:orphan-impls, r=Veykril

    feat: Diagnose some orphan trait impl cases
    bors committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    6e4538a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e21d21a View commit details
    Browse the repository at this point in the history
  9. Auto merge of rust-lang#15893 - Veykril:unsafe-impls-diagnostic, r=Ve…

    …ykril
    
    Diagnose incorrect unsafety for trait impls
    bors committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    989000b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    723d799 View commit details
    Browse the repository at this point in the history
  11. Auto merge of rust-lang#15895 - Veykril:unsafe-impls-diagnostic, r=Ve…

    …ykril
    
    Diagnose missing assoc items in trait impls
    bors committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    c1e65aa View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    df62962 View commit details
    Browse the repository at this point in the history
  13. Fix panic in add_type_ascription

    Assist wasn't applicable when the let statement was missing a pattern
    before, so we should do the same now.
    DropDemBits committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    3f99a56 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Configuration menu
    Copy the full SHA
    610eafe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b53c09 View commit details
    Browse the repository at this point in the history
  3. Auto merge of rust-lang#15899 - lnicola:sync-from-rust, r=Veykril

    internal: Sync from rust
    bors committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f888a6e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fb70fe2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c94a6af View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    498f39e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a473303 View commit details
    Browse the repository at this point in the history
  8. Auto merge of rust-lang#15874 - DropDemBits:structured-snippet-migrat…

    …e-4, r=Veykril
    
    internal: Migrate assists to the structured snippet API, part 4
    
    Continuing from rust-lang#15260
    
    Migrates the following assists:
    - `add_turbo_fish`
    - `add_type_ascription`
    - `destructure_tuple_binding`
    - `destructure_tuple_binding_in_subpattern`
    
    I did this a while ago, but forgot to make a PR for the changes until now. 😅
    bors committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    535eb0d View commit details
    Browse the repository at this point in the history
  9. Auto merge of rust-lang#15901 - Veykril:inner-diag, r=lnicola

    fix: Diagnose everything in nested items, not just def diagnostics
    
    Turns out we only calculated def diagnostics for these before (was wondering why I wasn't getting any type mismatches)
    bors committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    57ef70c View commit details
    Browse the repository at this point in the history
  10. Bump anyhow

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    dfc885e View commit details
    Browse the repository at this point in the history
  11. Bump itertools

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f66df10 View commit details
    Browse the repository at this point in the history
  12. Bump tracing

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f53368d View commit details
    Browse the repository at this point in the history
  13. Bump tracing-tree

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    d83620a View commit details
    Browse the repository at this point in the history
  14. Bump tracing-subscriber

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    2dbdaa2 View commit details
    Browse the repository at this point in the history
  15. Bump either

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    cb8434e View commit details
    Browse the repository at this point in the history
  16. Bump serde

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    970a796 View commit details
    Browse the repository at this point in the history
  17. Bump serde_json

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    2bfd6b6 View commit details
    Browse the repository at this point in the history
  18. Bump indexmap

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    1fc056e View commit details
    Browse the repository at this point in the history
  19. Bump tracing-log

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    c4dfa06 View commit details
    Browse the repository at this point in the history
  20. Remove outdated comment

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    441e8c7 View commit details
    Browse the repository at this point in the history
  21. Bump chalk

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    a1f81a7 View commit details
    Browse the repository at this point in the history
  22. Bump text-size

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    5725832 View commit details
    Browse the repository at this point in the history
  23. Bump dissimilar

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    829cf8d View commit details
    Browse the repository at this point in the history
  24. Bump ra-ap-rustc_lexer

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    b267f6b View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    c66084b View commit details
    Browse the repository at this point in the history
  26. Fix builtin line! expansion

    Veykril committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e8c4007 View commit details
    Browse the repository at this point in the history
  27. Auto merge of rust-lang#15903 - Veykril:inner-diag, r=Veykril

    Fix builtin line! expansion
    
    `concat` expects only literals, not whole syntax nodes, so we need to expand as such
    bors committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    b8b4b22 View commit details
    Browse the repository at this point in the history
  28. Tweak tsconfig.json

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    8e8e7de View commit details
    Browse the repository at this point in the history
  29. Auto merge of rust-lang#15905 - lnicola:tsconfig, r=lnicola

    minor: Tweak tsconfig.json
    
    CC rust-lang/rust-analyzer#15904
    bors committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    1d3bf72 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    df7fa7f View commit details
    Browse the repository at this point in the history
  31. Auto merge of rust-lang#15904 - davidbarsky:davidbarsky/bump-minimum-…

    …vscode-version-to-1.78, r=lnicola
    
    editor/code: bump minimum version of VS Code to 1.78
    
    Undoes rust-lang/rust-analyzer#15333.
    bors committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    bae9c08 View commit details
    Browse the repository at this point in the history
  32. Bump tracing-tree again

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    83e6d79 View commit details
    Browse the repository at this point in the history
  33. Bump xshell

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    b18ce4f View commit details
    Browse the repository at this point in the history
  34. Bump rayon

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    2814d64 View commit details
    Browse the repository at this point in the history
  35. Bump cargo_metadata

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    3ed27d2 View commit details
    Browse the repository at this point in the history
  36. Bump bitflags

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    c6fad55 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    8ea06c8 View commit details
    Browse the repository at this point in the history
  38. Bump memchr

    lnicola committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    da24b6f View commit details
    Browse the repository at this point in the history
  39. Auto merge of rust-lang#15902 - lnicola:bump-deps, r=Veykril

    internal: Bump deps pt. 1
    bors committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    58de0b1 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Configuration menu
    Copy the full SHA
    0cd68bf View commit details
    Browse the repository at this point in the history
  2. Auto merge of rust-lang#15830 - davidbarsky:davidbarsky/allow-compani…

    …on-extension-to-call-rust-analyzer, r=davidbarsky
    
    code: expose workspaces to other extensions; remove `addProject` command
    
    This (mostly red) PR does three things:
    - Exposes two methods to companion extensions (`setWorkspaces` and `notifyRustAnalyzer`).
        - `setWorkspaces` is needed to update `linkedProjects` _without_ writing workspace/global configuration.
        - `notifyRustAnalyzer` to get the server to pull the new configuration.
    - Makes `Ctx` implement `RustAnalyzerExtensionApi` to prevent accidental regressions.
    - Remove `rust-analyzer.addProject`, as that will live in a buck2 companion extension. No need for that to be in rust-analyzer!
    
    I can see the utility of combining `notifyRustAnalyzer` and `setWorkspaces` into a single method (`updateWorkspacesAndNotify()`?), but I don't feel strongly about this. My feeling is that this API could be easily changed in the future.
    bors committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    37a8790 View commit details
    Browse the repository at this point in the history
  3. Bump libc

    lnicola committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    480cb60 View commit details
    Browse the repository at this point in the history
  4. Auto merge of rust-lang#15913 - lnicola:bump-libc, r=lnicola

    internal: Bump libc
    
    CC rust-lang#117981
    bors committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    141fc69 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    949870c View commit details
    Browse the repository at this point in the history