Add as_(mut_)ptr and as_(mut_)slice to raw array pointers #119411

yotamofek · 2023-12-29T15:36:49Z

Hey, first time contributing to the standard libraries so not completely sure about the process.

These functions are complementary to the ones being added in #74265 . I found them missing on array pointers.

See also:

rustbot · 2023-12-29T15:36:57Z

(rustbot has picked a reviewer for you, use r? to override)

Nilstrieb · 2023-12-29T18:54:45Z

Thank you for the PR! This PR contains a public library API change, which should follow the proper process: https://std-dev-guide.rust-lang.org/development/feature-lifecycle.html

yotamofek · 2023-12-29T20:17:57Z

@Nilstrieb thanks for the link!
Just making sure I'm parsing it correctly: it seems to me that if a proposed API has such a simple implementation, such as this one, then there's no need for an ACP?
Or is it better to go down the formal ACP route anyways?

Nilstrieb · 2023-12-29T22:19:12Z

I recommend opening an ACP anyways.

bors · 2024-01-20T12:12:12Z

☔ The latest upstream changes (presumably #120157) made this pull request unmergeable. Please resolve the merge conflicts.

yotamofek · 2024-01-20T13:39:38Z

@joshtriplett just a friendly ping, in case you missed this one (which makes sense, I opened it on December 29th haha). Thank you!

Nilstrieb

Sorry for the late response. I found some issues which need to be addressed before we can merge this (you don't have to address the "unimportant nit" ones if you don't want to).
Use @rustbot readywhen you've addressed the feedback.

Nilstrieb · 2024-01-27T11:40:34Z

library/core/src/ptr/const_ptr.rs

+    /// let arr: *const [i8; 3] = ptr::null();
+    /// assert_eq!(arr.as_ptr(), ptr::null());


unimportant nit: The example could be a bit more useful, showing a pointer to an actual array and then maybe passing as_ptr to copy_nonoverlapping to copy out of the array or something like that.

Nilstrieb · 2024-01-27T11:40:51Z

library/core/src/ptr/mut_ptr.rs

+    /// let arr: *mut [i8; 3] = ptr::null_mut();
+    /// assert_eq!(arr.as_mut_ptr(), ptr::null_mut());


unimportant nit: same here

library/core/src/ptr/mut_ptr.rs

library/core/src/ptr/const_ptr.rs

library/core/src/ptr/mut_ptr.rs

library/core/src/ptr/const_ptr.rs

yotamofek · 2024-01-27T15:48:37Z

@Nilstrieb thank you so much for your patient review, and terribly sorry for the silly copy-paste errors that I should have caught earlier. This is my first (somewhat) substantial contribution to rust, so I really appreciate it!

I elected to not change the examples for now. Also, made the mut methods const, because why not?

If github doesn't GC it, you can see just my CR fixes here: dd8b7ee

@rustbot ready

library/core/src/ptr/const_ptr.rs

library/core/src/ptr/mut_ptr.rs

bors · 2024-02-09T20:46:07Z

☔ The latest upstream changes (presumably #120676) made this pull request unmergeable. Please resolve the merge conflicts.

Nilstrieb

Thanks, this looks good now! I've left a response to your question, but if you can't be bothered to fix it that's okay, just say you're fine with it as-is (because I'm too, I just don't find it quite optimal) and then I'll approve it as-is. If you do want to fix it, fix it and I'll approve it.

library/core/src/ptr/const_ptr.rs

yotamofek · 2024-03-16T20:18:41Z

Thanks for the review! 🙏 Pushed a fix.

Nilstrieb · 2024-03-16T22:22:35Z

@bors r+

bors · 2024-03-16T22:22:37Z

📌 Commit d0c0887 has been approved by Nilstrieb

It is now in the queue for this repository.

Add as_(mut_)ptr and as_(mut_)slice to raw array pointers Hey, first time contributing to the standard libraries so not completely sure about the process. These functions are complementary to the ones being added in rust-lang#74265 . I found them missing on array pointers. See also: - ACP: rust-lang/libs-team#321 - Tracking issue: rust-lang#119834

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#119411 (Add as_(mut_)ptr and as_(mut_)slice to raw array pointers) - rust-lang#122248 (Respect stage0 sysroot when compiling rmake.rs with COMPILETEST_FORCE_STAGE0) - rust-lang#122295 (mir-opt: always run tests for the current target) - rust-lang#122574 (Register LLVM handlers for bad-alloc / OOM) - rust-lang#122608 (Move check-cfg diagnostic logic into a separate file) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#119411 - yotamofek:array-ptr-get, r=Nilstrieb Add as_(mut_)ptr and as_(mut_)slice to raw array pointers Hey, first time contributing to the standard libraries so not completely sure about the process. These functions are complementary to the ones being added in rust-lang#74265 . I found them missing on array pointers. See also: - ACP: rust-lang/libs-team#321 - Tracking issue: rust-lang#119834

rustbot assigned joshtriplett Dec 29, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 29, 2023

yotamofek changed the title ~~Add as_{mut}_ptr and as_{mut} slice to raw array pointers~~ Add as_{mut}_ptr and as_{mut}_slice to raw array pointers Dec 29, 2023

yotamofek force-pushed the array-ptr-get branch from 9269640 to 05e547e Compare December 29, 2023 20:21

yotamofek mentioned this pull request Dec 30, 2023

as_(mut_)ptr and as_(mut_)slice methods on raw array pointers rust-lang/libs-team#321

Closed

yotamofek mentioned this pull request Jan 10, 2024

Tracking Issue for raw array getters (array_ptr_get) #119834

Open

4 tasks

yotamofek changed the title ~~Add as_{mut}_ptr and as_{mut}_slice to raw array pointers~~ Add as_(mut_)ptr and as_(mut_)slice to raw array pointers Jan 10, 2024

yotamofek force-pushed the array-ptr-get branch from 05e547e to 5456dd6 Compare January 10, 2024 21:26

yotamofek force-pushed the array-ptr-get branch from 5456dd6 to fd3942d Compare January 20, 2024 13:32

Nilstrieb requested changes Jan 27, 2024

View reviewed changes

Nilstrieb assigned Nilstrieb and unassigned joshtriplett Jan 27, 2024

Nilstrieb added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2024

yotamofek force-pushed the array-ptr-get branch 2 times, most recently from dd8b7ee to 8836254 Compare January 27, 2024 15:39

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2024

yotamofek commented Jan 27, 2024

View reviewed changes

library/core/src/ptr/const_ptr.rs Outdated Show resolved Hide resolved

ollie27 reviewed Jan 27, 2024

View reviewed changes

library/core/src/ptr/const_ptr.rs Outdated Show resolved Hide resolved

library/core/src/ptr/mut_ptr.rs Outdated Show resolved Hide resolved

Nilstrieb added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2024

yotamofek force-pushed the array-ptr-get branch 2 times, most recently from 80b5af7 to 8775a7b Compare March 15, 2024 19:06

yotamofek requested a review from Nilstrieb March 16, 2024 18:19

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 16, 2024

Nilstrieb approved these changes Mar 16, 2024

View reviewed changes

library/core/src/ptr/const_ptr.rs Outdated Show resolved Hide resolved

Add as_(mut_)ptr and as_(mut_)slice to raw array pointers

d0c0887

yotamofek force-pushed the array-ptr-get branch from 8775a7b to d0c0887 Compare March 16, 2024 20:15

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2024

This was referenced Mar 17, 2024

Rollup of 6 pull requests #122624

Closed

Rollup of 5 pull requests #122625

Merged

bors merged commit 3c07321 into rust-lang:master Mar 17, 2024
11 checks passed

rustbot added this to the 1.79.0 milestone Mar 17, 2024

yotamofek deleted the array-ptr-get branch March 17, 2024 11:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add as_(mut_)ptr and as_(mut_)slice to raw array pointers #119411

Add as_(mut_)ptr and as_(mut_)slice to raw array pointers #119411

yotamofek commented Dec 29, 2023 •

edited

rustbot commented Dec 29, 2023

Nilstrieb commented Dec 29, 2023

yotamofek commented Dec 29, 2023

Nilstrieb commented Dec 29, 2023

bors commented Jan 20, 2024

yotamofek commented Jan 20, 2024

Nilstrieb left a comment •

edited

Nilstrieb Jan 27, 2024

Nilstrieb Jan 27, 2024

yotamofek commented Jan 27, 2024 •

edited

bors commented Feb 9, 2024

Nilstrieb left a comment

yotamofek commented Mar 16, 2024

Nilstrieb commented Mar 16, 2024

bors commented Mar 16, 2024

		/// let arr: *const [i8; 3] = ptr::null();
		/// assert_eq!(arr.as_ptr(), ptr::null());

		/// let arr: *mut [i8; 3] = ptr::null_mut();
		/// assert_eq!(arr.as_mut_ptr(), ptr::null_mut());

Add as_(mut_)ptr and as_(mut_)slice to raw array pointers #119411

Add as_(mut_)ptr and as_(mut_)slice to raw array pointers #119411

Conversation

yotamofek commented Dec 29, 2023 • edited

rustbot commented Dec 29, 2023

Nilstrieb commented Dec 29, 2023

yotamofek commented Dec 29, 2023

Nilstrieb commented Dec 29, 2023

bors commented Jan 20, 2024

yotamofek commented Jan 20, 2024

Nilstrieb left a comment • edited

Choose a reason for hiding this comment

Nilstrieb Jan 27, 2024

Choose a reason for hiding this comment

Nilstrieb Jan 27, 2024

Choose a reason for hiding this comment

yotamofek commented Jan 27, 2024 • edited

bors commented Feb 9, 2024

Nilstrieb left a comment

Choose a reason for hiding this comment

yotamofek commented Mar 16, 2024

Nilstrieb commented Mar 16, 2024

bors commented Mar 16, 2024

yotamofek commented Dec 29, 2023 •

edited

Nilstrieb left a comment •

edited

yotamofek commented Jan 27, 2024 •

edited