Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move check-cfg diagnostic logic into a separate file #122608

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Mar 16, 2024

as well as adding some triagebot mentions (for me) for check-cfg related files.

@rustbot label +F-check-cfg

@rustbot
Copy link
Collaborator

rustbot commented Mar 16, 2024

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Mar 16, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@Urgau Urgau changed the title Move ove diagnostic logic Move check-cfg diagnostic logic into a separate file Mar 16, 2024
@fmease
Copy link
Member

fmease commented Mar 16, 2024

r=me once CI green

@bors delegate+

@bors
Copy link
Contributor

bors commented Mar 16, 2024

✌️ @Urgau, you can now approve this pull request!

If @fmease told you to "r=me" after making some further change, please make that change, then do @bors r=@fmease

@Urgau
Copy link
Member Author

Urgau commented Mar 16, 2024

@bors r=@fmease rollup=always

@bors
Copy link
Contributor

bors commented Mar 16, 2024

📌 Commit ed0478a has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2024
@rustbot rustbot added the F-check-cfg --check-cfg label Mar 16, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 17, 2024
…gic, r=fmease

Move check-cfg diagnostic logic into a separate file

as well as adding some triagebot mentions (for me) for check-cfg related files.

`@rustbot` label +F-check-cfg
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#119411 (Add as_(mut_)ptr and as_(mut_)slice to raw array pointers)
 - rust-lang#122248 (Respect stage0 sysroot when compiling rmake.rs with COMPILETEST_FORCE_STAGE0)
 - rust-lang#122295 (mir-opt: always run tests for the current target)
 - rust-lang#122574 (Register LLVM handlers for bad-alloc / OOM)
 - rust-lang#122608 (Move check-cfg diagnostic logic into a separate file)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 325678c into rust-lang:master Mar 17, 2024
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2024
Rollup merge of rust-lang#122608 - Urgau:check-cfg-move-diagnostic-logic, r=fmease

Move check-cfg diagnostic logic into a separate file

as well as adding some triagebot mentions (for me) for check-cfg related files.

``@rustbot`` label +F-check-cfg
@rustbot rustbot added this to the 1.79.0 milestone Mar 17, 2024
@Urgau Urgau deleted the check-cfg-move-diagnostic-logic branch March 17, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself F-check-cfg --check-cfg S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants