Subtree update of `rust-analyzer` #120198

See: rust-lang#12613

Add a stable #visual-studio anchor to the Manual Helpful for rust-lang/www.rust-lang.org#1915 so we have a persistent place to link as "Visual Studio" from the Rust website. Syntax reference: https://docs.asciidoctor.org/asciidoc/latest/sections/custom-ids/#assign-auxiliary-ids

…rgo metadata`

…m-ra

Follow the rename in nightly (see https://blog.rust-lang.org/inside-rust/2023/10/23/coroutines.html)

internal: sync from downstream

…e, r=Veykril Rename generator to coroutine Follow the rename in nightly (see https://blog.rust-lang.org/inside-rust/2023/10/23/coroutines.html) This makes it much easier to test code with the nightly compiler.

internal: Eagerly lower enum variants in CrateDefMap construction

…Veykril internal: Speedup line index calculation via NEON for aarch64 This commit provides SIMD acceleration (via NEON) for `line-index` library on aarch64 architecture, which improves performance for Apple Silicon users (and potentially for future aarch64-based chips). The algorithm used here follows the same process as the original implementation using SSE2. Most of the vector instructions in SSE2 have corresponding parts in neon. The only issue is that there is no corresponding instruction for `_mm_movemask_epi8` in neon. To address this problem, I referred to the article at https://community.arm.com/arm-community-blogs/b/infrastructure-solutions-blog/posts/porting-x86-vector-bitmask-optimizations-to-arm-neon.

fix: failed to infer OUT_DIR when workspace root contains symlink fix rust-lang#15867

…d, r=Veykril Show which roots are being scanned in progress messages This changes the `Roots Scanned` message to include the directory being scanned. Before: `Roots Scanned 206/210 (98%)` After: `Roots Scanned 206/210: .direnv (98%)` This makes it a lot easier to tell that `rust-analyzer` isn't crashed, it's just trying to scan a huge directory. See: rust-lang#12613

internal: Make data queries transparent over their diagnostics variant And a few other QoL things

fix: Make `value_ty` query fallible

…o, r=Veykril internal: Follow rustfmt's algorithm for ordering imports when ordering and merging use trees Updates use tree ordering and merging utilities to follow rustfmt's algorithm for ordering imports. The [rustfmt implementation](https://github.com/rust-lang/rustfmt/blob/6356fca675bd756d71f5c123cd053d17b16c573e/src/imports.rs) was used as reference.

minor: Simplify

feat: Hover for literals showing additional value information

feat: Show notable trait impls on hover

feat: Goto type actions for notable trait hovers Follow up to rust-lang/rust-analyzer#16374

fix: better handling of SelfParam in assist 'inline_call' fix rust-lang#15470. The current `inline_call` directly translates `&self` into `let ref this = ...;` and `&mut self` into `let ref mut this = ...;`. However, it does not handle some complex scenarios. This PR addresses the following transformations (assuming the receiving object is `obj`): - `self`: `let this = obj` - `mut self`: `let mut this = obj` - `&self`: `let this = &obj` - `&mut self` + If `obj` is `let mut obj = ...`, use a mutable reference: `let this = &mut obj` + If `obj` is `let obj = &mut ...;`, perform a reborrow: `let this = &mut *obj`

Run metadata on sysroot for CI metrics

It's a call of the third token is neither IDENT or TRY

…r=Veykril `macro_rules` as macro name This PR makes RA parse `macro_rules! {}` (note the missing identifier) as a `MACRO_CALL` instead of `MACRO_RULES`. Fixes rust-lang#15969.

fix: Fix progress reporting getting stuck Fixes rust-lang/rust-analyzer#16382

internal: Fix sysroot metadata in metrics CC rust-lang/rust-analyzer#16380 (comment)

…t, r=lnicola internal: properly order raw idents when ordering use trees Follow up to rust-lang#16352 to properly order raw identifiers.

With rust-lang#15656 we started disallowing renaming of non-local items. Although this makes sense there are some false positives that impacted users' workflows. So this config aims to mitigate this by giving users the liberty to disable this feature.

…ith-memchr, r=Veykril internal: speedup LineEndings calculation using 'memchr' See rust-lang/rust-analyzer#13538

minor: Make use of some new `SmolStr` improvements

…kril fix: add error recovery for use_tree_list parsing This PR adds error recovery for USE_TREE_LIST parsing, avoid the wrong USE_TREE_LIST making the rest parsing incorrectly. before ![before](https://github.com/rust-lang/rust-analyzer/assets/71162630/c6643690-f25c-4ad9-93d9-e661ba5b1dc3) after ![after](https://github.com/rust-lang/rust-analyzer/assets/71162630/30a58c40-2711-48d2-b2e5-fb208fc8636c) close rust-lang/rust-analyzer#16227

The first one succeeds because the functionality is already implemented. The second one fails and represents the functionality to be implemented in this PR.

…onfig, r=Veykril Add a new config to allow renaming of non-local defs With rust-lang#15656 we started disallowing renaming of non-local items. Although this makes sense there are some false positives that impacted users' workflows. So this config aims to mitigate this by giving users the liberty to disable this feature. The reason why this is a draft is that I saw one of the tests fail and I am not sure if the "got" result even syntactically makes sense Test case is : ```rust check( "Baz", r#" //- /lib.rs crate:lib new_source_root:library pub struct S; //- /main.rs crate:main deps:lib new_source_root:local use lib::S$0; "#, "use lib::Baz;" ); ``` ``` Left: use lib::Baz; Right: use lib::Baz;Baz Diff: use lib::Baz;Baz ```

Fix intra doc links Fixes rust-lang#15848

Refactor `macro_call` to be consistent with other functions rust-lang/rust-analyzer#16314 (comment)

… r=Veykril feat: Add "One" import granularity Adds a new import granularity option "One" that merges all imports into a single use statement as long as they have the same visibility and attributes. This is similar to [rustfmt's `imports_granularity = "One"`](https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=import#imports_granularity). Fixes: rust-lang#11361

Even though we changed the name of the config I forgot to update the warning message that referenced it.

`cargo clippy --fix` This PR is the result of running `cargo clippy --fix && cargo fmt` in the root of the repository. I did not manually review all the changes, but just skimmed through a few of them. The tests still pass, so it seems fine.

They will be removed one by one

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>

…ef_config, r=Veykril Update bail message referencing config Even though we changed the name of the config I forgot to update the warning message that referenced it.

internal: Record FnAbi This unfortunately breaks our lub coercions, so will need to look into fixing that first, though I am not sure what is going wrong where... Stubbed some stuff out for the time being.

Expand lint tables && make clippy happy 🎉 This PR expands the lint tables on `./Cargo.toml` and thereby makes `cargo clippy` exit successfully! 🎉 Fixes rust-lang#15918 ## How? In the beginning there are some warnings for rustc. Next, and most importantly, there is the clippy lint table. There are a few sections in there. First there are the lint groups. Second there are all lints which are permanently allowed with the reasoning why they are allowed. Third there is a huge list of temporarily allowed lints. They should be removed in the mid-term, but incur a substantial amount of work, therefore they are allowed for now and can be worked on bit by bit. Fourth there are all lints which should warn. Additionally there are a few allow statements in the code for lints which should be permanently allowed in this specific place, but not in the whole code base. ## Follow up work - [ ] Run clippy in CI - [ ] Remove tidy test (at least `@Veykril` wrote this in rust-lang#15017) - [ ] Work on temporarily allowed lints

Work through temporarily allowed clippy lints, part 1 This is the first batch of not allowing but actually fixing the clippy lints. Each commit removes one lint from the lint table and then fixes the resulting warnings. Follow-up to rust-lang#16401

fix panic with reference in macro it panic at `builder.make_mut(segment)`, where segment is from macro expand. And the usage reference in orginal macro call isn't a `PathSegment` so we can't update it in `apply_references`, I can't find a way to deal with it properly so here just filter out the reference in macro. LMK if there are better way to fix this try to close rust-lang/rust-analyzer#16328

…lnicola fix: Include `for` construct in convert to guarded return conditions

internal: add `max_line_length` to `.editorconfig` This helps with setting proper visual guides/rulers for the right margin in some editors/IDEs (e.g. CLion)

…m-ra

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subtree update of `rust-analyzer` #120198

Subtree update of `rust-analyzer` #120198

Commits on Jan 9, 2024

Commits on Jan 11, 2024

Commits on Jan 12, 2024

Commits on Jan 14, 2024

Commits on Jan 15, 2024

Commits on Jan 16, 2024

Commits on Jan 17, 2024

Commits on Jan 18, 2024

Commits on Jan 19, 2024

Commits on Jan 20, 2024

Commits on Jan 21, 2024

Subtree update of rust-analyzer #120198

Subtree update of rust-analyzer #120198

Commits on Jan 9, 2024

Commits on Jan 11, 2024

Commits on Jan 12, 2024

Commits on Jan 14, 2024

Commits on Jan 15, 2024

Commits on Jan 16, 2024

Commits on Jan 17, 2024

Commits on Jan 18, 2024

Commits on Jan 19, 2024

Commits on Jan 20, 2024

Commits on Jan 21, 2024

Subtree update of `rust-analyzer` #120198

Subtree update of `rust-analyzer` #120198