Function ABI is irrelevant for reachability #123063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @michaelwoerister. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
tmiasko
force-pushed
the
reachability-abi
branch
from
9d5c91d
to
955f762
Compare
|
The code was originally introduced in 4ddeef3. It looks like it was made ineffective since we have distinction between Rust and C symbol export level (it exports symbols at Rust level, but it is used only for crate type with C level threshold). |
|
I agree, it looks like that can never make a difference, i.e. the code does something akin to: let exported = symbols.filter(|s| s.abi != Rust || extern(s)).filter(|s| extern(s))@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 28, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#123063 (Function ABI is irrelevant for reachability) - rust-lang#123096 (Don't check match scrutinee of postfix match for unused parens) - rust-lang#123146 (Use compiletest directives instead of manually checking TARGET / tools) - rust-lang#123160 (remove `def_id_to_node_id` in ast lowering) - rust-lang#123162 (Correctly get complete intra-doc link data) - rust-lang#123164 (Bump Unicode printables to version 15.1, align to unicode_data) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 28, 2024
Rollup merge of rust-lang#123063 - tmiasko:reachability-abi, r=michaelwoerister Function ABI is irrelevant for reachability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.