Skip to content

Rollup of 6 pull requests #123171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 28, 2024
Merged

Rollup of 6 pull requests #123171

merged 16 commits into from
Mar 28, 2024

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

tmiasko and others added 16 commits March 25, 2024 00:00
@tmiasko
Function ABI is irrelevant for reachability
955f762
@compiler-errors
Don't check match scrutinee of postfix match for unused parens
950b40f
@jieyouxu
Accept only-wasm32-wasip1 directives
1dcbc23
@jieyouxu
Use compiletest directives for properly only running wasm32-wasip1 te…
0885380 
…sts on that target
@jieyouxu
Convert wasmtime check into a compiletest needs directive
12e9992
@jieyouxu
Use compiletest directives for ignoring targets
9762d66
@bvanjoi
remove def_id_to_node_id in ast lowering
90306cd
@GuillaumeGomez
Correctly get complete intra-doc link data
75fedfc
@GuillaumeGomez
Add regression test for rust-lang#123158
f1cfbdb
@Marcondiro
Bump Unicode printables to version 15.1, align to unicode_data
e9870b5
@matthiaskrgr
Rollup merge of rust-lang#123063 - tmiasko:reachability-abi, r=michae…
732ded9 
…lwoerister

Function ABI is irrelevant for reachability
@matthiaskrgr
Rollup merge of rust-lang#123096 - compiler-errors:postfix-match-pare…
69cfe80 
…ns, r=fmease

Don't check match scrutinee of postfix match for unused parens

We only check the scrutinees of block-like constructs and a few others (return/index/assign/method calls). Just don't do it for postfix match at all.

Fixes rust-lang#123064

r? fmease
@matthiaskrgr
Rollup merge of rust-lang#123146 - jieyouxu:use-compiletest-directive…
d1630e5 
…s, r=clubby789

Use compiletest directives instead of manually checking TARGET / tools

Changes:

- Accept `ignore-wasm32-wasip1` and `needs-wasmtime` directives.
- Add support for needing `wasmtime` as a runner.
- Update wasm/compiler_builtin tests to use compiletest directives over manual checks.
@matthiaskrgr
Rollup merge of rust-lang#123160 - bvanjoi:cleanup, r=compiler-errors
1ec73f0 
remove `def_id_to_node_id` in ast lowering
@matthiaskrgr
Rollup merge of rust-lang#123162 - GuillaumeGomez:fix-123158, r=notri…
cba164c 
…ddle

Correctly get complete intra-doc link data

Fixes rust-lang#123158.

The problem was that we didn't take into account cases where there would be content other than backticks into the intra doc link definition.

r? `@notriddle`
@matthiaskrgr
Rollup merge of rust-lang#123164 - Marcondiro:unicode15-1, r=Manishearth
83b4d3d 
Bump Unicode printables to version 15.1, align to unicode_data

r? `@Manishearth`
Thanks!
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Mar 28, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Collaborator

bors commented Mar 28, 2024

📌 Commit 83b4d3d has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2024
@bors
Copy link
Collaborator

bors commented Mar 28, 2024

⌛ Testing commit 83b4d3d with merge ba52720...

@bors
Copy link
Collaborator

bors commented Mar 28, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing ba52720 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 28, 2024
@bors bors merged commit ba52720 into rust-lang:master Mar 28, 2024
@rustbot rustbot added this to the 1.79.0 milestone Mar 28, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#123063 Function ABI is irrelevant for reachability 5060fe75dbf58ffa7b87e201f043a9ddaeca91b3 (link)
#123096 Don't check match scrutinee of postfix match for unused par… b125c619d3b303928f7e0e11d7d2909ecb4dfc4e (link)
#123146 Use compiletest directives instead of manually checking TAR… 95ea00cb6993809dc839e4576d44584e77319053 (link)
#123160 remove def_id_to_node_id in ast lowering 01dfa37fb0dc77b74166f7d5d111353d1f75e6f0 (link)
#123162 Correctly get complete intra-doc link data dbaf026ae0f396ce8fb4e06f8fcf10ff725d9818 (link)
#123164 Bump Unicode printables to version 15.1, align to unicode_d… 5e91923a97eaceb9d80c3f25d241c6e026745520 (link)

previous master: 929bceeaf8

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ba52720): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.5% [-0.5%, -0.5%] 2
Improvements ✅
(secondary)		 -0.4% [-0.5%, -0.3%] 4
All ❌✅ (primary) -0.5% [-0.5%, -0.5%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.8% [1.5%, 2.1%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.8% [1.5%, 2.1%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.937s -> 670.106s (0.17%)
Artifact size: 315.71 MiB -> 315.70 MiB (-0.00%)

@Mark-Simulacrum
Copy link
Member

Looks to be just the good side of bimodality, not actual changes.

@matthiaskrgr matthiaskrgr deleted the rollup-7id2r8o branch September 1, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.