Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly get complete intra-doc link data #123162

Merged
merged 2 commits into from Mar 28, 2024

Conversation

GuillaumeGomez
Copy link
Member

Fixes #123158.

The problem was that we didn't take into account cases where there would be content other than backticks into the intra doc link definition.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 28, 2024
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 28, 2024

📌 Commit f1cfbdb has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#123063 (Function ABI is irrelevant for reachability)
 - rust-lang#123096 (Don't check match scrutinee of postfix match for unused parens)
 - rust-lang#123146 (Use compiletest directives instead of manually checking TARGET / tools)
 - rust-lang#123160 (remove `def_id_to_node_id` in ast lowering)
 - rust-lang#123162 (Correctly get complete intra-doc link data)
 - rust-lang#123164 (Bump Unicode printables to version 15.1, align to unicode_data)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cba164c into rust-lang:master Mar 28, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 28, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2024
Rollup merge of rust-lang#123162 - GuillaumeGomez:fix-123158, r=notriddle

Correctly get complete intra-doc link data

Fixes rust-lang#123158.

The problem was that we didn't take into account cases where there would be content other than backticks into the intra doc link definition.

r? `@notriddle`
@GuillaumeGomez GuillaumeGomez deleted the fix-123158 branch March 28, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc incorrectly raises a rustdoc::redundant_explicit_links warning when the link is in fact required
4 participants