Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #124358

Closed
wants to merge 20 commits into from

Commits on Apr 24, 2024

  1. Make LazyAttrTokenStream::encode panic.

    It's unreachable, because AST JSON printing support was removed some
    time ago.
    nnethercote committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    15e71b6 View commit details
    Browse the repository at this point in the history
  2. Remove MetaItemKind::value_str.

    `MetaItem::value_str` is good enough. And this makes
    `MetaItem::value_str` more like `MetaItem::meta_item_list` and
    `name_value_literal`.
    nnethercote committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d5ec9b4 View commit details
    Browse the repository at this point in the history
  3. Rename NestedMetaItem::name_value_literal.

    It's a highly misleading name, because it's completely different to
    `MetaItem::name_value_literal`. Specifically, it doesn't match
    `MetaItemKind::NameValue` (e.g. `#[foo = 3]`), it matches
    `MetaItemKind::List` (e.g. `#[foo(3)]`).
    nnethercote committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    8d4655d View commit details
    Browse the repository at this point in the history
  4. Remove unnecessary pubs in mut_visit.rs.

    This makes it clearer what is actually used outside of this crate.
    nnethercote committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    748b0a2 View commit details
    Browse the repository at this point in the history
  5. Whitespace fixes.

    nnethercote committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    78e7c7b View commit details
    Browse the repository at this point in the history
  6. Use a type alias for a CI job

    Kobzol committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2a7fe14 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e257359 View commit details
    Browse the repository at this point in the history
  8. Remove should-skip-this.sh

    Kobzol committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    246ee53 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4942a35 View commit details
    Browse the repository at this point in the history
  10. Fix documentation

    Kobzol committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    c59bc9a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c36d78e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f2b3f3e View commit details
    Browse the repository at this point in the history
  13. compiletest: add no-auto-check-cfg directive

    this directive prevents compiletest from adding any implicit and
    automatic --check-cfg arguments
    Urgau committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    16372f8 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b6ed813 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Add comments about attribute tokens.

    This clarifies something that has puzzled me for some time.
    nnethercote committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    2ae0765 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f3530cf View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#124257 - JoverZhang:rmake-diff, r=jieyouxu

    Rewrite the `no-input-file.stderr` test in Rust and support diff
    
    Rewrite the `no-input-file.stderr` test from rust-lang#121876.
    Use the `similar` lib to replace the `diff` command.
    matthiaskrgr committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1528aec View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#124324 - nnethercote:minor-ast-cleanups, r=…

    …estebank
    
    Minor AST cleanups
    
    r? `@estebank`
    matthiaskrgr committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    33a8b5b View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#124327 - Kobzol:ci-skip-jobs, r=pietroalbini

    CI: implement job skipping in Python matrix calculation
    
    This removes the `step` YAML anchor and the corresponding bash script.
    
    Best reviewed commit-by-commit.
    
    r? ``@pietroalbini``
    matthiaskrgr committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9cb72cb View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#124345 - Urgau:compiletest-check-cfg, r=jie…

    …youxu
    
    Enable `--check-cfg` by default in UI tests
    
    This PR enables-by-default `--check-cfg` in UI tests, now that it has become stable.
    
    To do so this PR does 2 main things:
     - it introduce the `no-auto-check-cfg` directive to `compiletest`, to prevent any `--check-cfg` args (only to be used for `--check-cfg` tests)
     - it updates the _remaining_[^1] UI tests by either:
         - allowing the lint when neither expecting the lint nor giving the check-cfg args make sense
         - give the appropriate check-cfg args
         - or expect the lint, when it useful
    
    [^1]: some preparation work was done in rust-lang#123577 rust-lang#123702
    
    I highly recommend reviewing this PR commit-by-commit.
    
    r? `@jieyouxu`
    matthiaskrgr committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    1972d40 View commit details
    Browse the repository at this point in the history