Fail on internal compiler errors in compile-fail #13967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need to temporarily ignore the tests, or fix them to land (as shown by the travis errors). If you ignore them, could you open an issue indicating what tests are ignored and place FIXME links at the top of the files? |
|
I can't fix the tests right now, I'm ignoring them and filing issues. |
This was referenced May 6, 2014
|
Issues/ignores in, I think this should pass now (it does locally) |
lilyball
changed the title
|
Fixed the typo in one of the commit messages. r? |
bors
added a commit
that referenced
this pull request
May 7, 2014
This change makes internal compile errors in the compile-fail tests failures. I believe this is the correct behaviour- those tests are intended to assert that the compiler doesn't proceed, not that it explodes. So far, it fails on 4 tests in my environment, my testcase for #13943 which is what caused me to tackle this, and 3 others: ``` failures: [compile-fail] compile-fail/incompatible-tuple.rs # This one is mine and not on master [compile-fail] compile-fail/inherit-struct8.rs [compile-fail] compile-fail/issue-9725.rs [compile-fail] compile-fail/unsupported-cast.rs ```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2023
minor: Add version placeholder to changelog template Closes rust-lang#13967 This isn't great because we need to fill it in manually, but getting the version number from GitHub Actions is a bit annoying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes internal compile errors in the compile-fail tests failures.
I believe this is the correct behaviour- those tests are intended to assert that the compiler doesn't proceed, not that it explodes.
So far, it fails on 4 tests in my environment, my testcase for #13943 which is what caused me to tackle this, and 3 others: