define Eq,TotalEq,Ord,TotalOrd for &mut T #14133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1244,6 +1244,9 @@ impl<T> Show for *T { | |||
| impl<T> Show for *mut T { | |||
| fn fmt(&self, f: &mut Formatter) -> Result { secret_pointer(self, f) } | |||
| } | |||
| impl<'a, T> Show for &'a mut T { | |||
| fn fmt(&self, f: &mut Formatter) -> Result { secret_pointer(self, f) } | |||
There was a problem hiding this comment.
Can you move this up to line 1124 next to the impl for &'a T, and use secret_show instead?
|
Looks good to me, thanks! Could you squash the commits together? Also, feel free to ping the PR whenever you update it, sadly github doesn't send out notifications! |
Also Show, which is useful in assertions. Fixes rust-lang#14074
|
Well, when in Rome I suppose. |
bors
added a commit
that referenced
this pull request
May 15, 2014
Also Show, which is useful in assertions. Fixes #14074
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2023
minor: Add version placeholder to changelog template Closes rust-lang#13967 This isn't great because we need to fill it in manually, but getting the version number from GitHub Actions is a bit annoying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also Show, which is useful in assertions. Fixes #14074