Issue 29161 #29415
Merged
Issue 29161 #29415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc #29161 |
|
@bors: r+ c70fd5825ed65a98dfd6d58675661a3abb371ebd |
brson
added
the
beta-nominated
|
This didn't land before 1.5 branched. |
|
⌛ Testing commit c70fd58 with merge 48b9c5a... |
|
💔 Test failed - auto-mac-64-opt |
`as_local_node_id`, instead just compare against `Some(id)`. Fixes rust-lang#29161.
nikomatsakis
force-pushed
the
issue-29161
branch
from
c70fd58 to
19996d4
Compare
|
@bors r+ |
|
📌 Commit 19996d4 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 28, 2015
Fix corner case in privacy that was causing ICEs when the `source_did` was not crate-local. Full confession: I only kinda sorta understand this code, but afaict it's legit for `source_did` to be from another crate. r? @alexcrichton
alexcrichton
added
the
beta-accepted
Merged
brson
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix corner case in privacy that was causing ICEs when the
source_didwas not crate-local.Full confession: I only kinda sorta understand this code, but afaict it's legit for
source_didto be from another crate.r? @alexcrichton