Distribute both rust-lldb and rust-gdb everywhere #32835
Conversation
|
This probably also needs to be changed in rustbuild... cc @alexcrichton |
brson
force-pushed
the
alldebug
branch
2 times, most recently
from
2bd83df
to
be736f9
Compare
|
(rustup and multirust both install the proxies on all platforms) |
|
The problem with this so far is that LLDB doesn't work all that well on Linux for Rust programs (at least the last time I checked) and the pre-installed version of GDB on OSX is very old and probably doesn't really support our pretty printers. I don't want to give the impression that we expect these combinations to work well out of the box. As a side note: In principle LLDB should work just fine on Linux. We just might have to tweak some small things in the DWARF we emit. |
|
@brson If we decide to do this, we should also clean up the now unneeded targets in debuggers.mk |
|
rustbuild changes look good to me at least |
|
Just an idea: we could also distribute a script called |
|
I'd be up for that. With 'also' you mean in addition to the existing ones? |
|
That sounds plausible to me, yeah. One part I also just remembered is that we probably don't want to distribute shell scripts on Windows as they only work in the MSYS shell, not anything else. We may want to just compile dedicated binaries perhaps? |
|
The correlation between users of msys and users of gdb/lldb is extremely high on Windows anyway, so I wouldn't be worried about providing those shell scripts with the |
|
☔ The latest upstream changes (presumably #32755) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I've updated this to distribute rust-lldb and rust-gdb everywhere except windows-msvc. I'm having second thoughts about adding Maybe there are other things we could do to guide people to the right one. Another option would be to make both of them rust-installer components, and make them optional on their 'bad' platforms so they wouldn't be installed by default. If we were to go that route though we should seriously consider converting them to cargo packages. |
|
cc @rust-lang/tools Trying to decide how to make both the rust-lldb / rust-gdb wrappers available to everyone while encourage lldb on os x and gdb on other unixes. I've proposed several things: adding a new |
|
This might be interesting: I've been tinkering with LLDB on Linux while trying to resolve some issues regarding newer LLDB versions, and it seems that LLDB is starting to become rather stable there. Though one problem currently is that only the "nightly" version will work at the moment, because it contains a patch to make it handle Rust programs again. |
I'm in favour of this, I find it awkward explaining to people about the debug scripts, and just having one would make it much easier (don't have to ask what platform they're on, etc.) I think it will be some time before we can really recommend lldb on Linux, especially since the Rust-specific stuff just landed in GDB. |
I wouldn't recommend it either. But distributing the rust-lldb script there seems viable to me now. |
agreed |
|
👎 on rust-dbg: lldb and gdb use quite different sets of commands, so it'll just add to confusion. The user will be able to launch a debugger, but what then? You need to know which one it is to do anything. |
|
I agree with @vadimcn and the hesitation to ship |
|
Agreed, I like shipping both but no
I think some documentation specifying this would be enough. Then again, I could be wrong... I'm still very much a noobie 😄 |
|
@michaelwoerister Let's just do it. There does seem to be a build failure though. |
|
I pushed an update that should fix build error, caused by debugger_pretty_printers_common.py being copied twice. |
|
One simple thing we could do is platform detection in rust-lldb/rust-gdb and warn on the lesser platform. |
Both debuggers are viable in some capacity on all tier-1 platforms, and people often ask for rust-lldb on Linux or rust-gdb on OS X.
|
@bors r+ We (or I) might just be overthinking this/be to careful. People will generally know which debugger works best on which platform. Let's not annoy them with warnings. |
|
📌 Commit 5ad99e2 has been approved by |
Distribute both rust-lldb and rust-gdb everywhere Both debuggers are viable in some capacity on all tier-1 platforms, and people often ask for rust-lldb on Linux or rust-gdb on OS X. r? @michaelwoerister I'm still testing locally, but this *looks* like the right thing to change.
Both debuggers are viable in some capacity on all tier-1 platforms,
and people often ask for rust-lldb on Linux or rust-gdb on OS X.
r? @michaelwoerister
I'm still testing locally, but this looks like the right thing to change.