Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: Add support for compiletest test suites #32755

Merged
merged 1 commit into from Apr 19, 2016

Conversation

Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@alexcrichton @rust-highfive @bors @brson @retep998
@alexcrichton
Copy link
Member

alexcrichton commented Apr 5, 2016

This commit adds support in rustbuild for running all of the compiletest test
suites as part of make check. The compiletest program was moved to
src/tools (like rustbook and others) and is now just compiled like any other
old tool. Each test suite has a pretty standard set of dependencies and just
tweaks various parameters to the final compiletest executable.

Note that full support is lacking in terms of:

  • Once a test suite has passed, that's not remembered. When a test suite is
    requested to be run, it's always run.
  • The arguments to compiletest probably don't work for every possible
    combination of platforms and testing environments just yet. There will likely
    need to be future updates to tweak various pieces here and there.
  • Cross compiled test suites probably don't work just yet, support for that will
    come in a follow-up patch.

@rust-highfive rust-highfive assigned brson Apr 5, 2016

@rust-highfive

This comment has been minimized.

Sign in to view
Copy link
Collaborator

rust-highfive commented Apr 5, 2016

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton referenced this pull request Apr 5, 2016

Closed

Tracking issue for rustbuild, the alternate build system for rustc #31590

42 of 48 tasks complete

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-start-test branch from 2a529e0 to f964407 Apr 5, 2016

@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 6, 2016

☔️ The latest upstream changes (presumably #32767) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-start-test branch from f964407 to 4bb22a5 Apr 6, 2016

@brson

This comment has been minimized.

Sign in to view
Copy link
Contributor

brson commented Apr 7, 2016

@bors r+
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 7, 2016

📌 Commit 4bb22a5 has been approved by brson
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 7, 2016

☔️ The latest upstream changes (presumably #32016) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-start-test branch 2 times, most recently from d766524 to e45739d Apr 8, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 8, 2016

@bors: r=brson e45739d
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 9, 2016

☔️ The latest upstream changes (presumably #32751) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-start-test branch from e45739d to b54aedf Apr 11, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 11, 2016

@bors: r=brson
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 11, 2016

📌 Commit b54aedf has been approved by brson
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 12, 2016

⌛️ Testing commit b54aedf with merge f836e04...

bors added a commit that referenced this pull request Apr 12, 2016

@bors
Auto merge of #32755 - alexcrichton:rustbuild-start-test, r=brson 
rustbuild: Add support for compiletest test suites

This commit adds support in rustbuild for running all of the compiletest test
suites as part of `make check`. The `compiletest` program was moved to
`src/tools` (like `rustbook` and others) and is now just compiled like any other
old tool. Each test suite has a pretty standard set of dependencies and just
tweaks various parameters to the final compiletest executable.

Note that full support is lacking in terms of:

* Once a test suite has passed, that's not remembered. When a test suite is
  requested to be run, it's always run.
* The arguments to compiletest probably don't work for every possible
  combination of platforms and testing environments just yet. There will likely
  need to be future updates to tweak various pieces here and there.
* Cross compiled test suites probably don't work just yet, support for that will
  come in a follow-up patch.
f836e04
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 12, 2016

💔 Test failed - auto-linux-64-x-android-t
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 12, 2016

☔️ The latest upstream changes (presumably #32804) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-start-test branch from b54aedf to 808116f Apr 12, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 12, 2016

@bors: r=brson 808116f
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 12, 2016

⌛️ Testing commit 808116f with merge 3147de8...

bors added a commit that referenced this pull request Apr 12, 2016

@bors
Auto merge of #32755 - alexcrichton:rustbuild-start-test, r=brson 
rustbuild: Add support for compiletest test suites

This commit adds support in rustbuild for running all of the compiletest test
suites as part of `make check`. The `compiletest` program was moved to
`src/tools` (like `rustbook` and others) and is now just compiled like any other
old tool. Each test suite has a pretty standard set of dependencies and just
tweaks various parameters to the final compiletest executable.

Note that full support is lacking in terms of:

* Once a test suite has passed, that's not remembered. When a test suite is
  requested to be run, it's always run.
* The arguments to compiletest probably don't work for every possible
  combination of platforms and testing environments just yet. There will likely
  need to be future updates to tweak various pieces here and there.
* Cross compiled test suites probably don't work just yet, support for that will
  come in a follow-up patch.
3147de8
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 12, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 13, 2016

☔️ The latest upstream changes (presumably #32590) made this pull request unmergeable. Please resolve the merge conflicts.
@retep998

This comment has been minimized.

Sign in to view
Copy link
Member

retep998 commented Apr 13, 2016

3221225781 → 0xC0000135 → STATUS_DLL_NOT_FOUND

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-start-test branch 2 times, most recently from f6027db to 9860b73 Apr 13, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 13, 2016

@bors: r=brson 9860b73
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 18, 2016

@bors: r=brson 2df14df
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 18, 2016

@retep998 if you take a look at the logs you'll notice that one of the tests caused compiletest to overflow the stack (don't worry, I can also read test logs).

So what's happening here is a // should-fail test, specifically meta-expected-error-wrong-rev, is indeed panicking (as it should fail). During this panic we're running SEH handlers, but one of them manages to cause a segfault. This in turns runs the SEH handlers, which in turn causes a segfault. Eventually we run out of stack and something dies even harder, causing the binary to crash.

The most terrifying part, however, is that a -C opt-level=2 compiletest doesn't exhibit this behavior, only a -C opt-level=3 one. Taking down the opt-level a bit and praying it works. Investigating this and reporting a but will... take awhile.
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 18, 2016

⌛️ Testing commit 2df14df with merge 48cf2cb...

bors added a commit that referenced this pull request Apr 18, 2016

@bors
Auto merge of #32755 - alexcrichton:rustbuild-start-test, r=brson 
rustbuild: Add support for compiletest test suites

This commit adds support in rustbuild for running all of the compiletest test
suites as part of `make check`. The `compiletest` program was moved to
`src/tools` (like `rustbook` and others) and is now just compiled like any other
old tool. Each test suite has a pretty standard set of dependencies and just
tweaks various parameters to the final compiletest executable.

Note that full support is lacking in terms of:

* Once a test suite has passed, that's not remembered. When a test suite is
  requested to be run, it's always run.
* The arguments to compiletest probably don't work for every possible
  combination of platforms and testing environments just yet. There will likely
  need to be future updates to tweak various pieces here and there.
* Cross compiled test suites probably don't work just yet, support for that will
  come in a follow-up patch.
48cf2cb
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 18, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-start-test branch from 2df14df to 0fca16d Apr 18, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 18, 2016

Score another one for too-long-paths on Windows.
@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 18, 2016

@bors: r=brson 0fca16d
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 18, 2016

☔️ The latest upstream changes (presumably #33042) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-start-test branch from 0fca16d to 27b0101 Apr 18, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 18, 2016

@bors: r=brson 27b0101
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 18, 2016

⌛️ Testing commit 27b0101 with merge 5221e22...

bors added a commit that referenced this pull request Apr 18, 2016

@bors
Auto merge of #32755 - alexcrichton:rustbuild-start-test, r=brson 
rustbuild: Add support for compiletest test suites

This commit adds support in rustbuild for running all of the compiletest test
suites as part of `make check`. The `compiletest` program was moved to
`src/tools` (like `rustbook` and others) and is now just compiled like any other
old tool. Each test suite has a pretty standard set of dependencies and just
tweaks various parameters to the final compiletest executable.

Note that full support is lacking in terms of:

* Once a test suite has passed, that's not remembered. When a test suite is
  requested to be run, it's always run.
* The arguments to compiletest probably don't work for every possible
  combination of platforms and testing environments just yet. There will likely
  need to be future updates to tweak various pieces here and there.
* Cross compiled test suites probably don't work just yet, support for that will
  come in a follow-up patch.
5221e22
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 18, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-start-test branch from 27b0101 to 1e96856 Apr 18, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 18, 2016

@bors: r=brson 1e96856
@alexcrichton
rustbuild: Add support for compiletest test suites 
This commit adds support in rustbuild for running all of the compiletest test
suites as part of `make check`. The `compiletest` program was moved to
`src/tools` (like `rustbook` and others) and is now just compiled like any other
old tool. Each test suite has a pretty standard set of dependencies and just
tweaks various parameters to the final compiletest executable.

Note that full support is lacking in terms of:

* Once a test suite has passed, that's not remembered. When a test suite is
  requested to be run, it's always run.
* The arguments to compiletest probably don't work for every possible
  combination of platforms and testing environments just yet. There will likely
  need to be future updates to tweak various pieces here and there.
* Cross compiled test suites probably don't work just yet, support for that will
  come in a follow-up patch.
Loading status checks…
b325baf

@alexcrichton alexcrichton force-pushed the alexcrichton:rustbuild-start-test branch from 1e96856 to b325baf Apr 18, 2016

@alexcrichton

This comment has been minimized.

Sign in to view
Copy link
Member Author

alexcrichton commented Apr 18, 2016

@bors: r=brson b325baf
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Apr 19, 2016

⌛️ Testing commit b325baf with merge d36ad55...

bors added a commit that referenced this pull request Apr 19, 2016

@bors
Auto merge of #32755 - alexcrichton:rustbuild-start-test, r=brson 
rustbuild: Add support for compiletest test suites

This commit adds support in rustbuild for running all of the compiletest test
suites as part of `make check`. The `compiletest` program was moved to
`src/tools` (like `rustbook` and others) and is now just compiled like any other
old tool. Each test suite has a pretty standard set of dependencies and just
tweaks various parameters to the final compiletest executable.

Note that full support is lacking in terms of:

* Once a test suite has passed, that's not remembered. When a test suite is
  requested to be run, it's always run.
* The arguments to compiletest probably don't work for every possible
  combination of platforms and testing environments just yet. There will likely
  need to be future updates to tweak various pieces here and there.
* Cross compiled test suites probably don't work just yet, support for that will
  come in a follow-up patch.
d36ad55
@bors

@bors bors merged commit b325baf into rust-lang:master Apr 19, 2016
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
homu Test successful
Details

This was referenced Apr 19, 2016

Merged
Merged
Merged
Merged

@retep998 retep998 referenced this pull request Apr 20, 2016

Merged

rustc: Implement custom panic runtimes #32900

@alexcrichton alexcrichton deleted the alexcrichton:rustbuild-start-test branch May 2, 2016

@alexcrichton alexcrichton referenced this pull request May 2, 2016

Closed

MSVC: Segfaults with opt-level=3 plus unwinding #33352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.