Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the docs on str::trim_matches #33645

Merged
merged 1 commit into from Jun 7, 2016

Conversation

withoutboats
Copy link
Contributor

This pattern cannot be a str because str's pattern is not double-ended.

This pattern cannot be a str because str's pattern is not double-ended.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gankro (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@withoutboats
Copy link
Contributor Author

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned Gankra May 15, 2016
@birkenfeld
Copy link
Contributor

While at it, could we add &[char] to the list of acceptable types for the trim methods?

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jun 6, 2016

📌 Commit ae14223 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jun 7, 2016
…oc, r=steveklabnik

Correct the docs on str::trim_matches

This pattern cannot be a str because str's pattern is not double-ended.
bors added a commit that referenced this pull request Jun 7, 2016
Rollup of 13 pull requests

- Successful merges: #33645, #33897, #33945, #34007, #34060, #34070, #34094, #34098, #34099, #34104, #34124, #34125, #34138
- Failed merges:
@bors bors merged commit ae14223 into rust-lang:master Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants