Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise wording in Rc documentation. #34097

Merged
merged 2 commits into from
Jul 8, 2016
Merged

Revise wording in Rc documentation. #34097

merged 2 commits into from
Jul 8, 2016

Conversation

lambdacat
Copy link

The term "thread-local" has a widely accepted meaning which is not
the meaning it's used for here.

The term "thread-local" has a widely-accepted meaning which is not
the meaning it's used for here.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aturon
Copy link
Member

aturon commented Jun 6, 2016

Thanks, good catch!

For the sake of non-concurrency experts, I wonder if we can take your wording, but then also add a clarification -- "usable only within a single thread", or something like that.

@GuillaumeGomez
Copy link
Member

I'm not sure this new wording is better. I think a longer one would fit the most.

@apasel422
Copy link
Contributor

What's the status of this?

@GuillaumeGomez
Copy link
Member

@apasel422: No news from @arbitrary-cat, so no idea...

@lambdacat
Copy link
Author

How's that?

@steveklabnik
Copy link
Member

Looks great to me, thanks for coming back to this!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jul 7, 2016

📌 Commit 46e7c9e has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 8, 2016
Revise wording in Rc documentation.

The term "thread-local" has a widely accepted meaning which is not
the meaning it's used for here.
bors added a commit that referenced this pull request Jul 8, 2016
Rollup of 9 pull requests

- Successful merges: #34097, #34456, #34610, #34612, #34659, #34688, #34691, #34699, #34700
- Failed merges:
bors added a commit that referenced this pull request Jul 8, 2016
Rollup of 9 pull requests

- Successful merges: #34097, #34456, #34610, #34612, #34659, #34688, #34691, #34699, #34700
- Failed merges:
@bors bors merged commit 46e7c9e into rust-lang:master Jul 8, 2016
bors added a commit that referenced this pull request Jul 15, 2017
support pub(restricted) in thread_local! (round 2)

Resurrected #40984 now that the issue blocking it was fixed. Original description:

`pub(restricted)` was stabilized in #40556 so let's go!

Here is a [playground](https://play.rust-lang.org/?gist=f55f32f164a6ed18c219fec8f8293b98&version=nightly&backtrace=1).

I changed the interface of `__thread_local_inner!`, which is supposedly unstable but this is not checked for macros (#34097 cc @petrochenkov @jseyfried), so this may be an issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants