enhancewindows documentation in getting-started #34699
Conversation
- minor pronoun fix We -> You - PATH troubleshooting - dir output is vertical (but did not include timestamps) - executables not in %PATH% require .\
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -11,7 +11,7 @@ an Internet connection to run the commands in this section, as we’ll be | |||
| downloading Rust from the Internet. | |||
|
|
|||
| We’ll be showing off a number of commands using a terminal, and those lines all | |||
| start with `$`. We don't need to type in the `$`s, they are there to indicate | |||
| start with `$`. You don't need to type in the `$`s, they are there to indicate | |||
There was a problem hiding this comment.
This is the "author's we", and we pretty much use it everywhere. I can see why this might be a bit more clear. It's fine.
|
@bors: r+ rollup thank you! |
|
📌 Commit 1f99c29 has been approved by |
enhancewindows documentation in getting-started - minor pronoun fix We -> You - PATH troubleshooting - dir output is vertical (but did not include timestamps) - executables not in %PATH% require .\ r? @steveklabnik
enhancewindows documentation in getting-started - minor pronoun fix We -> You - PATH troubleshooting - dir output is vertical (but did not include timestamps) - executables not in %PATH% require .\ r? @steveklabnik
r? @steveklabnik