-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix std::path::Path::file_name()
doc
#34659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -1542,6 +1541,11 @@ impl Path { | |||
/// let os_str = OsStr::new("foo.txt"); | |||
/// | |||
/// assert_eq!(Some(os_str), path.file_name()); | |||
/// | |||
/// // Other examples: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we put these in a separate doc block rather than extending this one?
GuillaumeGomez
force-pushed
the
path_file_name
branch
from
July 5, 2016 15:55
9d33fe9
to
6109ef5
Compare
@bors: r+ rollup |
📌 Commit 6109ef5 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jul 5, 2016
…eveklabnik Fix `std::path::Path::file_name()` doc Fixes rust-lang#34632 r? @steveklabnik
@bors: r-
|
GuillaumeGomez
force-pushed
the
path_file_name
branch
from
July 5, 2016 23:26
6109ef5
to
0d78f6b
Compare
@steveklabnik: I have put back the imports. |
@bors: r+ rollup |
📌 Commit 0d78f6b has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 8, 2016
…eveklabnik Fix `std::path::Path::file_name()` doc Fixes rust-lang#34632 r? @steveklabnik
bors
added a commit
that referenced
this pull request
Jul 8, 2016
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 8, 2016
…eveklabnik Fix `std::path::Path::file_name()` doc Fixes rust-lang#34632 r? @steveklabnik
bors
added a commit
that referenced
this pull request
Jul 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34632
r? @steveklabnik