Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0132 update #35264

Merged
merged 3 commits into from Aug 5, 2016
Merged

E0132 update #35264

merged 3 commits into from Aug 5, 2016

Conversation

GuillaumeGomez
Copy link
Member

@sophiajt
Copy link
Contributor

sophiajt commented Aug 3, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Aug 3, 2016

📌 Commit 1607d5b has been approved by jonathandturner

@sophiajt
Copy link
Contributor

sophiajt commented Aug 3, 2016

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 3, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Aug 3, 2016

📌 Commit 1607d5b has been approved by jonathandturner

}
if let Some(ref mut span) = span {
span.lo = span.lo - BytePos(1);
span.hi = span.hi + BytePos(1);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't account for

fn f<  T  >() {}
      ^^^

I decided to omit this manual span expansion in my implementation of this method. #35257

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 4, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 4, 2016
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 5, 2016
bors added a commit that referenced this pull request Aug 5, 2016
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 5, 2016
bors added a commit that referenced this pull request Aug 5, 2016
@bors bors merged commit 1607d5b into rust-lang:master Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants