Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0060 e0061 format update #35289

Merged
merged 3 commits into from Aug 5, 2016
Merged

Conversation

leikahing
Copy link
Contributor

@leikahing leikahing commented Aug 4, 2016

This fixes #35215 and fixes #35216 as part of #35233

A separate issue will be opened to track the bonus portion of the tickets as @jaredwy will be handling that part.

?r @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb
Copy link
Member

eddyb commented Aug 4, 2016

r? @jonathandturner

@rust-highfive rust-highfive assigned sophiajt and unassigned eddyb Aug 4, 2016
@leikahing
Copy link
Contributor Author

Oh whoops, thanks for the fixed callout @eddyb.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 4, 2016

📌 Commit ded0d51 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 4, 2016
… r=jonathandturner

E0060 e0061 format update

This fixes rust-lang#35215 and fixes rust-lang#35216 as part of rust-lang#35233

A separate issue will be opened to track the bonus portion of the tickets as @jaredwy will be handling that part.

?r @jonathandturner
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 4, 2016
… r=jonathandturner

E0060 e0061 format update

This fixes rust-lang#35215 and fixes rust-lang#35216 as part of rust-lang#35233

A separate issue will be opened to track the bonus portion of the tickets as @jaredwy will be handling that part.

?r @jonathandturner
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 5, 2016
… r=jonathandturner

E0060 e0061 format update

This fixes rust-lang#35215 and fixes rust-lang#35216 as part of rust-lang#35233

A separate issue will be opened to track the bonus portion of the tickets as @jaredwy will be handling that part.

?r @jonathandturner
bors added a commit that referenced this pull request Aug 5, 2016
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 5, 2016
… r=jonathandturner

E0060 e0061 format update

This fixes rust-lang#35215 and fixes rust-lang#35216 as part of rust-lang#35233

A separate issue will be opened to track the bonus portion of the tickets as @jaredwy will be handling that part.

?r @jonathandturner
bors added a commit that referenced this pull request Aug 5, 2016
@bors bors merged commit ded0d51 into rust-lang:master Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E0061 needs to be updated to new format E0060 needs to be updated to new format
5 participants