Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated error message E0252 #35362

Merged
merged 1 commit into from
Aug 7, 2016
Merged

Updated error message E0252 #35362

merged 1 commit into from
Aug 7, 2016

Conversation

medzin
Copy link
Contributor

@medzin medzin commented Aug 5, 2016

Fixes #35306 as part of #35233.

r? @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 5, 2016

📌 Commit ef23c94 has been approved by GuillaumeGomez

@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 5, 2016
Merged
@GuillaumeGomez
Copy link
Member

@bors: rollup-

bors added a commit that referenced this pull request Aug 5, 2016
@bors
Auto merge of #35365 - GuillaumeGomez:rollup, r=GuillaumeGomez
b30eff7 
Rollup of 30 pull requests

- Successful merges: #34319, #35041, #35042, #35076, #35109, #35137, #35175, #35181, #35182, #35189, #35239, #35264, #35266, #35281, #35285, #35289, #35291, #35294, #35296, #35297, #35298, #35299, #35318, #35319, #35324, #35326, #35328, #35333, #35359, #35362
- Failed merges:
@sophiajt
Copy link
Contributor

sophiajt commented Aug 5, 2016

Thanks for the PR!

Looks like there are other tests that need to be updated. If you run git grep E0252 after updating, you should see the other test.

@TimNN
Copy link
Contributor

TimNN commented Aug 5, 2016

@jonathandturner sadly the failing tests don't include the error code.

@medzin the tests that fail are compile-fail/issue-26886.rs and compile-fail/use-mod.rs as far as I can tell, see #35365 (comment).

@bors
Copy link
Contributor

bors commented Aug 5, 2016

⌛ Testing commit ef23c94 with merge 073cbb6...

bors added a commit that referenced this pull request Aug 5, 2016
@bors
Auto merge of #35362 - medzin:E0252, r=GuillaumeGomez
073cbb6 
Updated error message E0252

Fixes #35306 as part of #35233.

r? @GuillaumeGomez
@sophiajt
Copy link
Contributor

sophiajt commented Aug 5, 2016

You should be able run it against all the compile-fail tests using:

python src/bootstrap/bootstrap.py --stage 1 --step check-cfail

@bors
Copy link
Contributor

bors commented Aug 5, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@sophiajt
Copy link
Contributor

sophiajt commented Aug 5, 2016

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 5, 2016

📌 Commit 3a255d8 has been approved by jonathandturner

@eddyb eddyb mentioned this pull request Aug 6, 2016
Merged
@GuillaumeGomez
Copy link
Member

@bors: r-

@medzin: Please squash your last commit.

@medzin
Copy link
Contributor Author

medzin commented Aug 6, 2016

@GuillaumeGomez done

bors added a commit that referenced this pull request Aug 6, 2016
@bors
Auto merge of #35407 - eddyb:rollup, r=eddyb
444ff9f 
Rollup of 21 pull requests

- Successful merges: #33951, #34916, #35287, #35288, #35351, #35353, #35356, #35362, #35363, #35364, #35366, #35368, #35370, #35372, #35373, #35374, #35375, #35376, #35380, #35393, #35394
- Failed merges: #35331, #35395
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 6, 2016

📌 Commit f4dd1f9 has been approved by GuillaumeGomez

@bors
Copy link
Contributor

bors commented Aug 6, 2016

⌛ Testing commit f4dd1f9 with merge 1518459...

bors added a commit that referenced this pull request Aug 6, 2016
@bors
Auto merge of #35362 - medzin:E0252, r=GuillaumeGomez
1518459 
Updated error message E0252

Fixes #35306 as part of #35233.

r? @GuillaumeGomez
@bors
Copy link
Contributor

bors commented Aug 6, 2016

💔 Test failed - auto-linux-64-debug-opt

@sophiajt
Copy link
Contributor

sophiajt commented Aug 6, 2016

@bors retry

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 6, 2016
Rollup merge of rust-lang#35362 - medzin:E0252, r=GuillaumeGomez
fbd7c55 
Updated error message E0252

Fixes rust-lang#35306 as part of rust-lang#35233.

r? @GuillaumeGomez
@sophiajt sophiajt mentioned this pull request Aug 6, 2016
Closed
bors added a commit that referenced this pull request Aug 6, 2016
@bors
Auto merge of #35430 - jonathandturner:rollup, r=jonathandturner
f0d7e4e 
Rollup of 9 pull requests

- Successful merges: #35362, #35393, #35394, #35402, #35410, #35411, #35413, #35419, #35421
- Failed merges: #35395, #35415
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge of rust-lang#35362 - medzin:E0252, r=GuillaumeGomez
7794eb6 
Updated error message E0252

Fixes rust-lang#35306 as part of rust-lang#35233.

r? @GuillaumeGomez
@sophiajt sophiajt mentioned this pull request Aug 7, 2016
Closed
@bors
Copy link
Contributor

bors commented Aug 7, 2016

⌛ Testing commit f4dd1f9 with merge f5e7a59...

bors added a commit that referenced this pull request Aug 7, 2016
@bors
Auto merge of #35362 - medzin:E0252, r=GuillaumeGomez
f5e7a59 
Updated error message E0252

Fixes #35306 as part of #35233.

r? @GuillaumeGomez
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge of rust-lang#35362 - medzin:E0252, r=GuillaumeGomez
262c91f 
Updated error message E0252

Fixes rust-lang#35306 as part of rust-lang#35233.

r? @GuillaumeGomez
@sophiajt sophiajt mentioned this pull request Aug 7, 2016
Closed
@bors
Copy link
Contributor

bors commented Aug 7, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild
Approved by: GuillaumeGomez
Pushing f5e7a59 to master...

@bors bors merged commit f4dd1f9 into rust-lang:master Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@medzin @rust-highfive @GuillaumeGomez @bors @sophiajt @TimNN