Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `$crate`-related regressions #37361

Merged
merged 3 commits into from Oct 26, 2016

Conversation

Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jseyfried @petrochenkov @nrc @bors
@jseyfried
Copy link
Contributor

jseyfried commented Oct 23, 2016

Fixes #37345, fixes #37357, fixes #37352, and improves the unused_extern_crates lint.
r? @nrc

@rust-highfive rust-highfive assigned nrc Oct 23, 2016

@jseyfried jseyfried force-pushed the jseyfried:fix_crate_var_regressions branch from 1cf3220 to 9106d21 Oct 23, 2016

This was referenced Oct 23, 2016

Closed
Closed
Closed
@petrochenkov

This comment has been minimized.

Sign in to view
Copy link
Contributor

petrochenkov commented Oct 23, 2016

FWIW, local use $crate; is very similar to use::super; importing the crate root from #37156.
I'd say both should be legal and import a special unusable name, and use $crate as x;/use::super as x; should be legal and declare name x referring to the root module.

@kvark kvark referenced this pull request Oct 24, 2016

Closed

GFX is broken on nightly #1070

@nrc

This comment has been minimized.

Sign in to view
Copy link
Member

nrc commented Oct 25, 2016

@bors r+

Could you file a tracking issue for use $crate; please?
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 25, 2016

📌 Commit 9106d21 has been approved by nrc

@jseyfried jseyfried referenced this pull request Oct 25, 2016

Open

Tracking issue for `use $crate;` compatibility warning #37390

@jseyfried

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jseyfried commented Oct 25, 2016

cc #37390
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 25, 2016

☔️ The latest upstream changes (presumably #37292) made this pull request unmergeable. Please resolve the merge conflicts.

@jseyfried jseyfried force-pushed the jseyfried:fix_crate_var_regressions branch from 9106d21 to 0d30325 Oct 25, 2016

@jseyfried

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jseyfried commented Oct 25, 2016

@bors r=nrc
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 25, 2016

📌 Commit 0d30325 has been approved by nrc
@jseyfried

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jseyfried commented Oct 25, 2016

@bors p=1 (this is causing a lot of regressions in practice)
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented Oct 26, 2016

⌛️ Testing commit 0d30325 with merge a7557e7...

bors added a commit that referenced this pull request Oct 26, 2016

@bors
Auto merge of #37361 - jseyfried:fix_crate_var_regressions, r=nrc 
Fix `$crate`-related regressions

Fixes #37345, fixes #37357, fixes #37352, and improves the `unused_extern_crates` lint.
r? @nrc
Loading status checks…
a7557e7
@bors

@bors bors merged commit 0d30325 into rust-lang:master Oct 26, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@jseyfried jseyfried deleted the jseyfried:fix_crate_var_regressions branch Oct 26, 2016

@retep998 retep998 referenced this pull request Oct 27, 2016

Merged

Add NCryptFreeObject #319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.