Add proper help line for -C inline threshold
#44548
Conversation
Also remove a period on a different help line for consistency
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/librustc/session/config.rs
Outdated
| @@ -1052,7 +1052,7 @@ options! {DebuggingOptions, DebuggingSetter, basic_debugging_options, | |||
| linker_flavor: Option<LinkerFlavor> = (None, parse_linker_flavor, [UNTRACKED], | |||
| "Linker flavor"), | |||
| fuel: Option<(String, u64)> = (None, parse_optimization_fuel, [TRACKED], | |||
| "Set the optimization fuel quota for a crate."), | |||
| "Set the optimization fuel quota for a crate"), | |||
| print_fuel: Option<String> = (None, parse_opt_string, [TRACKED], | |||
| "Make Rustc print the total optimization fuel used by a crate."), | |||
There was a problem hiding this comment.
Didn't notice this one. Should I remove and make them start with lowercase so that everything is the same then?
| @@ -1052,7 +1052,7 @@ options! {DebuggingOptions, DebuggingSetter, basic_debugging_options, | |||
| linker_flavor: Option<LinkerFlavor> = (None, parse_linker_flavor, [UNTRACKED], | |||
| "Linker flavor"), | |||
| fuel: Option<(String, u64)> = (None, parse_optimization_fuel, [TRACKED], | |||
| "Set the optimization fuel quota for a crate."), | |||
There was a problem hiding this comment.
This is one of two options that is capitalized. All the others start with lowercase letters.
|
The options under |
aidanhs
added
the
S-waiting-on-review
|
review ping @arielb1! pinging you on irc too! |
|
@bors r+ |
|
📌 Commit e89748e has been approved by |
Add proper help line for `-C inline threshold` Looks like someone accidentally some words when adding this. This also remove a period on a different help line for consistency, as no options have a period.
Looks like someone accidentally some words when adding this.
This also remove a period on a different help line for consistency, as no options have a period.