Rollup of 14 pull requests #45261
Merged
Rollup of 14 pull requests #45261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We describe the representation of C strings, and the purpose of OsString/OsStr. Part of rust-lang#29354
Explain the struct's reason for being, and its most common usage patterns. Add a bunch of links. Clarify the method docs a bit. Part of rust-lang#29354
Another part of rust-lang#30197
`let x = { ..default(), } // This comma is an error`
output message is shown in another 'help:' block line with +100 columns formatted test adjusted
This commit updates LLVM with a patch that's landed upstream to fix an assertion that was tripping when ThinLTO was activated. Unfortunately I wasn't able to get a reduced test case, but I've tested manually on the affected crates and the assertion is indeed fixed. Closes rust-lang#45131
1. Add -f flag to curl, so when the server returns 403 or 500 it will fail immediately. 2. Moved the checksum part into the retry loop, assuming checksum failure is due to broken download that can be fixed by downloading again.
… the beginning Per rust-lang#44855 (comment) and subsequent ones.
When attempting to mutate an immutable outer variable from a closure, point at the outer variable and suggest making it mutable.
…a from after identifier
The RLS currently is rebuilt every time you test it because the `OPENSSL_DIR` env var is changing, which is in turn caused by an accidental omission of `prepare_tool_cargo` when testing the RLS.
This commit updates the reachability pass of the compiler to seed the local worklist with `#[linkage]`-like items anywhere in a crate, not just those reachable from public items. Closes rust-lang#45165
…eklabnik Improved docs for CStr, CString, OsStr, OsString This expands the documentation for those structs and their corresponding traits, per rust-lang#29354
Improve newtype_index macro to handle description and constants consistently
Better compile error output when using arguments instead of types Following @estebank sugestion on issue rust-lang#18945 (comment)
…tolnay usize index message for vec
…r=petrochenkov Add suggestions for misspelled labels Another part of rust-lang#30197
…henkov Better error message for comma after base struct rust-lang#41834 This adds a better error for commas after the base struct: ``` let foo = Foo { one: 111, ..Foo::default(), // This comma is a syntax error }; ``` The current error is a generic `expected one of ...` which isn't beginner-friendly. My error looks like this: ``` error: cannot use a comma after the base struct --> tmp/example.rs:26:9 | 26 | ..Foo::default(), | ^^^^^^^^^^^^^^^^- help: remove this comma | = note: the base struct expansion must always be the last field ``` I even added a note for people who don't know why this isn't allowed.
…michaelwoerister rustc: Handle `#[no_mangle]` anywhere in a crate This commit updates the reachability pass of the compiler to seed the local worklist with `#[no_mangle]`-like items anywhere in a crate, not just those reachable from public items. Closes rust-lang#45165
…woerister rustc: Update LLVM with a ThinLTO fix This commit updates LLVM with a patch that's landed upstream to fix an assertion that was tripping when ThinLTO was activated. Unfortunately I wasn't able to get a reduced test case, but I've tested manually on the affected crates and the assertion is indeed fixed. Closes rust-lang#45131
…nload-error, r=Mark-Simulacrum rustbuild: Make openssl download more reliable. 1. Add `-f` flag to curl, so when the server returns 403 or 500 it will fail immediately. 2. Moved the checksum part into the retry loop, assuming checksum failure is due to broken download that can be fixed by downloading again. This PR is created responding to two recent spurious failures in rust-lang#45075 (comment) and rust-lang#45030 (comment). r? @Mark-Simulacrum , cc @aidanhs
Point at immutable outer variable When attempting to mutate an immutable outer variable from a closure, point at the outer variable and suggest making it mutable. Fix rust-lang#41790.
…ulacrum rustbuild: Prevent spurious rebuilds of the RLS The RLS currently is rebuilt every time you test it because the `OPENSSL_DIR` env var is changing, which is in turn caused by an accidental omission of `prepare_tool_cargo` when testing the RLS.
…vements, r=QuietMisdreavus Mobile sidebar improvements Very small changes, I just made the width of the sidebar of 100% and centered vertically both items a bit more: <img width="1440" alt="screen shot 2017-10-12 at 20 00 47" src="https://user-images.githubusercontent.com/3050060/31511496-302bb474-af88-11e7-8dab-2c88799eafcc.png"> r? @rust-lang/docs
…, r=QuietMisdreavus Rustdoc: Increase padding between consecutive impls Currently, [implementors](https://doc.rust-lang.org/nightly/std/iter/trait.IntoIterator.html#implementors) list is a bit too condensed. More spacing makes the list easier to read. Check out [this comment](rust-lang#41879 (comment)) to see what's the effect of this change. Closes rust-lang#41879. cc @QuietMisdreavus
Clarify how needs_drop is conservative
|
Some changes occurred in HTML/CSS. |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=14 |
|
📌 Commit 8ea6790 has been approved by |
kennytm
added
the
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[no_mangle]anywhere in a crate #45189, rustc: Update LLVM with a ThinLTO fix #45203, rustbuild: Make openssl download more reliable. #45209, Point at immutable outer variable #45221, rustbuild: Prevent spurious rebuilds of the RLS #45236, Mobile sidebar improvements #45240, Rustdoc: Increase padding between consecutive impls #45245, Clarify how needs_drop is conservative #45253