Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use InternedString rather than Name for RegionParameterDef #49913

Merged
merged 1 commit into from
Apr 14, 2018
Merged

Use InternedString rather than Name for RegionParameterDef #49913

merged 1 commit into from
Apr 14, 2018

Conversation

varkor
Copy link
Member

@varkor varkor commented Apr 12, 2018

This makes it consistent with TypeParameterDef.

r? @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2018
@eddyb
Copy link
Member

eddyb commented Apr 12, 2018

LGTM. r? @michaelwoerister

@varkor varkor force-pushed the RegionParameterDef-InternedString branch 2 times, most recently from 571b2d1 to e2f880d Compare April 12, 2018 23:00
@rust-lang rust-lang deleted a comment from rust-highfive Apr 12, 2018
@rust-lang rust-lang deleted a comment from rust-highfive Apr 12, 2018
@michaelwoerister
Copy link
Member

I'm fine with this too. @petrochenkov might want to take a look regarding hygiene implications.

@michaelwoerister
Copy link
Member

r? @petrochenkov

@petrochenkov
Copy link
Contributor

r=me after fixing compilation failures in rustc_driver

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2018
@varkor varkor mentioned this pull request Apr 13, 2018
Open
@varkor
Use InternedString rather than Name for RegionParameterDef
6234d41 
This makes it consistent with TypeParameterDef.
@varkor varkor force-pushed the RegionParameterDef-InternedString branch from e2f880d to 6234d41 Compare April 13, 2018 17:41
@rust-lang rust-lang deleted a comment from rust-highfive Apr 13, 2018
@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 13, 2018

📌 Commit 6234d41 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Apr 14, 2018
@kennytm
Rollup merge of rust-lang#49913 - varkor:RegionParameterDef-InternedS…
6f629d3 
…tring, r=petrochenkov

Use InternedString rather than Name for RegionParameterDef

This makes it consistent with `TypeParameterDef`.
@kennytm kennytm mentioned this pull request Apr 14, 2018
Merged
bors added a commit that referenced this pull request Apr 14, 2018
@bors
Auto merge of #49939 - kennytm:rollup, r=kennytm
21dae95 
Rollup of 14 pull requests

Successful merges: #49908, #49876, #49916, #49951, #49465, #49922, #49866, #49915, #49886, #49913, #49852, #49958, #49871, #49864

Failed merges:
@bors bors merged commit 6234d41 into rust-lang:master Apr 14, 2018
@varkor varkor deleted the RegionParameterDef-InternedString branch April 14, 2018 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@varkor @eddyb @michaelwoerister @petrochenkov @bors @rust-highfive