-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #50191
Rollup of 11 pull requests #50191
Commits on Mar 28, 2018
-
std: Child::kill() returns error if process has already exited
This patch makes it clear in std::process::Child::kill()'s API documentation that an error is returned if the child process has already cleanly exited. This is implied by the example, but not called out explicitly.
Configuration menu - View commit details
-
Copy full SHA for 7eb9a09 - Browse repository at this point
Copy the full SHA 7eb9a09View commit details -
Configuration menu - View commit details
-
Copy full SHA for d541282 - Browse repository at this point
Copy the full SHA d541282View commit details
Commits on Mar 29, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 51dc630 - Browse repository at this point
Copy the full SHA 51dc630View commit details
Commits on Apr 6, 2018
-
Stjepan Glavina committed
Apr 6, 2018 Configuration menu - View commit details
-
Copy full SHA for f86deef - Browse repository at this point
Copy the full SHA f86deefView commit details -
Stjepan Glavina committed
Apr 6, 2018 Configuration menu - View commit details
-
Copy full SHA for 9377340 - Browse repository at this point
Copy the full SHA 9377340View commit details -
Stjepan Glavina committed
Apr 6, 2018 Configuration menu - View commit details
-
Copy full SHA for 5dcce51 - Browse repository at this point
Copy the full SHA 5dcce51View commit details
Commits on Apr 8, 2018
-
Configuration menu - View commit details
-
Copy full SHA for fd2afa0 - Browse repository at this point
Copy the full SHA fd2afa0View commit details
Commits on Apr 14, 2018
-
Add doc links to
std::os
extension traitsAdd documentation links to the original type for various OS-specific extension traits and normalize the language for introducing such traits. Also, remove some outdated comments around the extension trait definitions.
Configuration menu - View commit details
-
Copy full SHA for 182d99c - Browse repository at this point
Copy the full SHA 182d99cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5bee64 - Browse repository at this point
Copy the full SHA d5bee64View commit details
Commits on Apr 15, 2018
-
Deprecate Read::chars and char::decode_utf8
Per FCP: * rust-lang#27802 (comment) * rust-lang#33906 (comment)
Configuration menu - View commit details
-
Copy full SHA for 7cbeddb - Browse repository at this point
Copy the full SHA 7cbeddbView commit details -
The unstable-feature attribute requires an issue (neglecting it is E0547), which gets used in the error messages. Unfortunately, there are some cases where "0" is apparently used a placeholder where no issue exists, directing the user to see the (nonexistent) issue #0. (It would have been better to either let `issue` be optional—compare to how issue is an `Option<u32>` in the feature-gate declarations in libsyntax/feature-gate.rs—or actually require that an issue be created.) Rather than endeavoring to change how `#[unstable]` works at this time (given competing contributor and reviewer priorities), this simple patch proposes the less-ambitious solution of just not adding the "(see issue)" note when the number is zero. Resolves rust-lang#49983.
Configuration menu - View commit details
-
Copy full SHA for e77110e - Browse repository at this point
Copy the full SHA e77110eView commit details
Commits on Apr 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 5fe8c59 - Browse repository at this point
Copy the full SHA 5fe8c59View commit details
Commits on Apr 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for bc4bd56 - Browse repository at this point
Copy the full SHA bc4bd56View commit details
Commits on Apr 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for bf816a2 - Browse repository at this point
Copy the full SHA bf816a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3af118 - Browse repository at this point
Copy the full SHA c3af118View commit details
Commits on Apr 21, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 79b1127 - Browse repository at this point
Copy the full SHA 79b1127View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b6933c - Browse repository at this point
Copy the full SHA 6b6933cView commit details
Commits on Apr 23, 2018
-
Use FxHashMap in syntax_pos::symbol::Interner::intern.
Because it's faster than HashMap. This change reduces the time taken for a few of the rustc-perf benchmarks, mostly the small ones, by up to 5%.
Configuration menu - View commit details
-
Copy full SHA for f7d4c97 - Browse repository at this point
Copy the full SHA f7d4c97View commit details -
core: Fix overflow in
int::mod_euc
whenself < 0 && rhs == MIN
Daiki Mizukami committedApr 23, 2018 Configuration menu - View commit details
-
Copy full SHA for fbb1c28 - Browse repository at this point
Copy the full SHA fbb1c28View commit details -
Clarify the docs for Cell::update
Stjepan Glavina committedApr 23, 2018 Configuration menu - View commit details
-
Copy full SHA for 1c0db24 - Browse repository at this point
Copy the full SHA 1c0db24View commit details -
Daiki Mizukami committed
Apr 23, 2018 Configuration menu - View commit details
-
Copy full SHA for 104c64d - Browse repository at this point
Copy the full SHA 104c64dView commit details -
Stjepan Glavina committed
Apr 23, 2018 Configuration menu - View commit details
-
Copy full SHA for 29e9de8 - Browse repository at this point
Copy the full SHA 29e9de8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f33af5c - Browse repository at this point
Copy the full SHA f33af5cView commit details
Commits on Apr 24, 2018
-
Rollup merge of rust-lang#49461 - andreastt:child-kill-exited, r=Mark…
…-Simulacrum std: Child::kill() returns error if process has already exited This patch makes it clear in std::process::Child::kill()'s API documentation that an error is returned if the child process has already cleanly exited. This is implied by the example, but not called out explicitly.
Configuration menu - View commit details
-
Copy full SHA for cefdd6d - Browse repository at this point
Copy the full SHA cefdd6dView commit details -
Rollup merge of rust-lang#49727 - stjepang:cell-update, r=SimonSapin
Add Cell::update This commit adds a new method `Cell::update`, which applies a function to the value inside the cell. Previously discussed in: rust-lang/rfcs#2171 ### Motivation Updating `Cell`s is currently a bit verbose. Here are several real examples (taken from rustc and crossbeam): ```rust self.print_fuel.set(self.print_fuel.get() + 1); self.diverges.set(self.diverges.get() | Diverges::Always); let guard_count = self.guard_count.get(); self.guard_count.set(guard_count.checked_add(1).unwrap()); if guard_count == 0 { // ... } ``` With the addition of the new method `Cell::update`, this code can be simplified to: ```rust self.print_fuel.update(|x| x + 1); self.diverges.update(|x| x | Diverges::Always); if self.guard_count.update(|x| x.checked_add(1).unwrap()) == 1 { // ... } ``` ### Unresolved questions 1. Should we return the old value instead of the new value (like in `fetch_add` and `fetch_update`)? 2. Should the return type simply be `()`? 3. Naming: `update` vs `modify` vs `mutate` etc. cc @SimonSapin
Configuration menu - View commit details
-
Copy full SHA for 91cc872 - Browse repository at this point
Copy the full SHA 91cc872View commit details -
Rollup merge of rust-lang#49812 - ehuss:ui-test-revisions, r=nikomats…
…akis Fix revision support for UI tests. Fixes rust-lang#48878
Configuration menu - View commit details
-
Copy full SHA for b9dbf8e - Browse repository at this point
Copy the full SHA b9dbf8eView commit details -
Rollup merge of rust-lang#49829 - ecstatic-morse:os-docs, r=steveklabnik
Add doc links to `std::os` extension traits Addresses a small subset of rust-lang#29367. This adds documentation links to the original type for various OS-specific extension traits, and uses a common sentence for introducing such traits (which now consistently ends in a period).
Configuration menu - View commit details
-
Copy full SHA for 2701c17 - Browse repository at this point
Copy the full SHA 2701c17View commit details -
Rollup merge of rust-lang#49906 - kennytm:stable-unreachable, r=sfackler
Stabilize `std::hint::unreachable_unchecked`. Closes rust-lang#43751.
Configuration menu - View commit details
-
Copy full SHA for f28f5aa - Browse repository at this point
Copy the full SHA f28f5aaView commit details -
Rollup merge of rust-lang#49970 - SimonSapin:deprecate, r=sfackler
Deprecate Read::chars and char::decode_utf8 Per FCP: * rust-lang#27802 (comment) * rust-lang#33906 (comment)
Configuration menu - View commit details
-
Copy full SHA for 6b1ed8e - Browse repository at this point
Copy the full SHA 6b1ed8eView commit details -
Rollup merge of rust-lang#49985 - zackmdavis:0, r=estebank
don't see issue #0 The unstable-feature attribute requires an issue (neglecting it is E0547), which gets used in the error messages. Unfortunately, there are some cases where "0" is apparently used a placeholder where no issue exists, directing the user to see the (nonexistent) issue #0. (It would have been better to either let `issue` be optional—compare to how issue is an `Option<u32>` in the feature-gate declarations in libsyntax/feature-gate.rs—or actually require that an issue be created.) Rather than endeavoring to change how `#[unstable]` works at this time (given competing contributor and reviewer priorities), this simple patch proposes the less-ambitious solution of just not adding the "(see issue)" note when the number is zero. Resolves rust-lang#49983.
Configuration menu - View commit details
-
Copy full SHA for 7c552a2 - Browse repository at this point
Copy the full SHA 7c552a2View commit details -
Rollup merge of rust-lang#50118 - GuillaumeGomez:search-bar-bug, r=Qu…
…ietMisdreavus fix search bar bug Fixes rust-lang#50064. r? @QuietMisdreavus
Configuration menu - View commit details
-
Copy full SHA for 05ef5bc - Browse repository at this point
Copy the full SHA 05ef5bcView commit details -
Rollup merge of rust-lang#50139 - nivkner:docs, r=steveklabnik
encourage descriptive issue titles There are two sides to avoiding duplicate issues, searching for existing ones, and making sure existing ones can be searched for. This addresses the later. r? @steveklabnik
Configuration menu - View commit details
-
Copy full SHA for 8545ecd - Browse repository at this point
Copy the full SHA 8545ecdView commit details -
Rollup merge of rust-lang#50174 - nnethercote:FxHashMap-Interner, r=m…
…ichaelwoerister Use FxHashMap in syntax_pos::symbol::Interner::intern. Because it's faster than HashMap. This change reduces the time taken for a few of the rustc-perf benchmarks, mostly the small ones, by up to 5%. ``` coercions avg: -1.3% min: -5.5% max: -0.0% helloworld-check avg: -2.3% min: -3.5% max: -1.8% deeply-nested-check avg: -1.4% min: -3.2% max: -0.5% tuple-stress-opt avg: -0.7% min: -2.0% max: -0.1% unify-linearly-check avg: -1.2% min: -1.9% max: -0.6% coercions-check avg: -0.8% min: -1.3% max: -0.4% unused-warnings-check avg: -1.0% min: -1.3% max: -0.8% deeply-nested-opt avg: -0.5% min: -1.2% max: -0.2% deeply-nested avg: -0.7% min: -1.2% max: -0.4% helloworld avg: -0.8% min: -1.1% max: -0.7% tuple-stress-check avg: -0.5% min: -1.0% max: -0.1% unused-warnings avg: -0.8% min: -1.0% max: -0.7% unused-warnings-opt avg: -0.8% min: -1.0% max: -0.7% coercions-opt avg: -0.5% min: -1.0% max: -0.1% helloworld-opt avg: -0.7% min: -1.0% max: -0.6% ```
Configuration menu - View commit details
-
Copy full SHA for 8d0c5da - Browse repository at this point
Copy the full SHA 8d0c5daView commit details -
Rollup merge of rust-lang#50185 - dmizuk:mod_euc-fix-overflow, r=kennytm
core: Fix overflow in `int::mod_euc` when `self < 0 && rhs == MIN` This commit removes usage of `abs`, which overflows when `self == MIN`.
Configuration menu - View commit details
-
Copy full SHA for 893774e - Browse repository at this point
Copy the full SHA 893774eView commit details