Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit building rustdoc without compiler artifacts #51302

Merged
merged 1 commit into from
Jun 3, 2018

Conversation

Mark-Simulacrum
Copy link
Member

No description provided.

@Mark-Simulacrum
Copy link
Member Author

r? @QuietMisdreavus

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2018
This avoids a full compiler build in order to build and/or run tests for
rustdoc.
@QuietMisdreavus
Copy link
Member

During a conversation on IRC i was confused about what this was doing, but after reading the commit message now i get it. Correct, after we removed the html-diff dependency we no longer need proc-macros just to build rustdoc. r=me pending travis

@Mark-Simulacrum
Copy link
Member Author

@bors r=QuietMisdreavus

@bors
Copy link
Contributor

bors commented Jun 2, 2018

📌 Commit cf24a1d has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 2, 2018
…etMisdreavus

Permit building rustdoc without compiler artifacts

None
bors added a commit that referenced this pull request Jun 2, 2018
Rollup of 6 pull requests

Successful merges:

 - #50167 ( Add as_nanos function to Duration)
 - #50919 (Provide more context for what the {f32,f64}::EPSILON values represent.)
 - #51124 (Reword {ptr,mem}::replace docs.)
 - #51147 (Stabilize SliceIndex trait.)
 - #51291 (Fix typos of ‘ambiguous’)
 - #51302 (Permit building rustdoc without compiler artifacts)

Failed merges:
@bors bors merged commit cf24a1d into rust-lang:master Jun 3, 2018
@Mark-Simulacrum Mark-Simulacrum deleted the rustdoc-fast branch June 8, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants