Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reword {ptr,mem}::replace docs. #51124

Merged
merged 1 commit into from
Jun 3, 2018
Merged

Reword {ptr,mem}::replace docs. #51124

merged 1 commit into from
Jun 3, 2018

Conversation

frewsxcv
Copy link
Member

Fixes #50657.

@rust-highfive
Copy link
Collaborator

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2018
@frewsxcv frewsxcv mentioned this pull request May 28, 2018
Closed
@shepmaster
Copy link
Member

I'm not a fan of the phrase "behind the mutable {pointer,reference}", but this probably belongs to someone with more appropriate view of the docs.

r? @QuietMisdreavus

@QuietMisdreavus
Copy link
Member

I agree that the phrasing is a little awkward. How about:

Moves src into the (referenced|pointed) dest, returning the previous dest value.

@frewsxcv
Copy link
Member Author

frewsxcv commented Jun 2, 2018

I agree that the phrasing is a little awkward. How about:

Moves src into the (referenced|pointed) dest, returning the previous dest value.

sgtm! adjusted in the latest force push

@QuietMisdreavus
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 2, 2018

📌 Commit 61b5bd2 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 2, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#51124 - frewsxcv:frewsxcv-replace, r=QuietM…
dd61a32 
…isdreavus

Reword {ptr,mem}::replace docs.

Fixes rust-lang#50657.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 2, 2018
Merged
bors added a commit that referenced this pull request Jun 2, 2018
@bors
Auto merge of #51310 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
3515dab 
Rollup of 6 pull requests

Successful merges:

 - #50167 ( Add as_nanos function to Duration)
 - #50919 (Provide more context for what the {f32,f64}::EPSILON values represent.)
 - #51124 (Reword {ptr,mem}::replace docs.)
 - #51147 (Stabilize SliceIndex trait.)
 - #51291 (Fix typos of ‘ambiguous’)
 - #51302 (Permit building rustdoc without compiler artifacts)

Failed merges:
@bors bors merged commit 61b5bd2 into rust-lang:master Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frewsxcv @rust-highfive @shepmaster @QuietMisdreavus @bors